Skip to content

[compiler] Refactor createTemporaryPlace #30585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

gsathya
Copy link
Contributor

@gsathya gsathya commented Aug 2, 2024

Stack from ghstack (oldest at bottom):

Update createTemporaryPlace to use makeTemporary and also rename
makeTemporary to makeTemporaryIdentifier to make it less ambiguous.

Update createTemporaryPlace to use makeTemporary and also rename
makeTemporary to makeTemporaryIdentifier to make it less ambiguous.

[ghstack-poisoned]
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 6:31pm

gsathya added a commit that referenced this pull request Aug 2, 2024
Update createTemporaryPlace to use makeTemporary and also rename
makeTemporary to makeTemporaryIdentifier to make it less ambiguous.

ghstack-source-id: b5955d3
Pull Request resolved: #30585
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Aug 2, 2024
@gsathya
Copy link
Contributor Author

gsathya commented Aug 2, 2024

Follow up from #30545 (comment)

@gsathya gsathya merged commit 7cf36c6 into gh/gsathya/15/base Aug 6, 2024
19 checks passed
gsathya added a commit that referenced this pull request Aug 6, 2024
Update createTemporaryPlace to use makeTemporary and also rename
makeTemporary to makeTemporaryIdentifier to make it less ambiguous.

ghstack-source-id: b5955d3
Pull Request resolved: #30585
@gsathya gsathya deleted the gh/gsathya/15/head branch August 6, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants