[ci] Parallelize yarn build #30071

poteto · 2024-06-24T17:55:46Z

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

vercel · 2024-06-24T17:55:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 12, 2024 3:11pm

ghstack-source-id: 636f2bb Pull Request resolved: #30071

[ghstack-poisoned]

ghstack-source-id: 4cf4021 Pull Request resolved: #30071

[ghstack-poisoned]

ghstack-source-id: d14f9ea Pull Request resolved: #30071

[ghstack-poisoned]

ghstack-source-id: 3cb64db Pull Request resolved: #30071

[ghstack-poisoned]

ghstack-source-id: 33b498f Pull Request resolved: #30071

react-sizebot · 2024-06-24T18:00:26Z

Comparing: e6783e7...72a15f5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.68 kB	6.68 kB	=	1.83 kB	1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	=	497.99 kB	497.99 kB	=	89.27 kB	89.27 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.69 kB	6.69 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	=	502.81 kB	502.81 kB	=	89.97 kB	89.97 kB
facebook-www/ReactDOM-prod.classic.js	=	597.08 kB	597.08 kB	=	105.33 kB	105.33 kB
facebook-www/ReactDOM-prod.modern.js	=	571.42 kB	571.42 kB	=	101.27 kB	101.27 kB
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	62.88 kB	0.00 kB	Deleted	15.69 kB	0.00 kB

Generated by 🚫 dangerJS against 72a15f5

[ghstack-poisoned]

ghstack-source-id: 0767a1f Pull Request resolved: #30071

[ghstack-poisoned]

ghstack-source-id: 2beffba Pull Request resolved: #30071

[ghstack-poisoned]

ghstack-source-id: fc61ba2 Pull Request resolved: #30071

[ghstack-poisoned]

ghstack-source-id: 78cf030 Pull Request resolved: #30071

[ghstack-poisoned]

ghstack-source-id: c93d81e Pull Request resolved: #30071

[ghstack-poisoned]

poteto · 2024-07-12T15:23:43Z

scripts/rollup/build-ghaction.js

I will unfork this later

jackpope · 2024-07-12T15:28:12Z

scripts/rollup/build-ghaction.js

@@ -0,0 +1,869 @@
+'use strict';


Review note: diffed this against rollup/build.js locally. Its mostly a copy with some changes to how we get node count from the runner. LGTM, assume we'll remove rollup/build.js once this is stable.

yeah I'm gonna remove the circleci hardcoding later in the stack and unfork these files

jackpope · 2024-07-12T15:29:33Z

.github/workflows/runtime_build.yml

+    strategy:
+      matrix:
+        # yml is dumb. update the --total arg to yarn build if you change the number of workers
+        worker_id: [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19]


Curious why 20 workers. Does this match the number of bundles?

I preserved our current circleci setup, where we have 20 workers for stable and 20 workers for experimental. That's the same as what this config in GH expands to

ghstack-source-id: 8a13b45 Pull Request resolved: #30071

Update

8bda34d

[ghstack-poisoned]

poteto mentioned this pull request Jun 24, 2024

[ci] Add yarn build gh action #30070

Merged

poteto added a commit that referenced this pull request Jun 24, 2024

[ci] Parallelize yarn build and yarn lint-build

d60ac44

ghstack-source-id: 636f2bb Pull Request resolved: #30071

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 24, 2024

Update

0f25805

[ghstack-poisoned]

poteto added a commit that referenced this pull request Jun 24, 2024

[ci] Parallelize yarn build and yarn lint-build

3fbb286

ghstack-source-id: 4cf4021 Pull Request resolved: #30071

Update

4e5b45e

[ghstack-poisoned]

poteto added a commit that referenced this pull request Jun 24, 2024

[ci] Parallelize yarn build and yarn lint-build

5fbacc7

ghstack-source-id: d14f9ea Pull Request resolved: #30071

Update

4fc3526

[ghstack-poisoned]

poteto added a commit that referenced this pull request Jun 24, 2024

[ci] Parallelize yarn build and yarn lint-build

3499075

ghstack-source-id: 3cb64db Pull Request resolved: #30071

Update

25a6144

[ghstack-poisoned]

poteto added a commit that referenced this pull request Jun 24, 2024

[ci] Parallelize yarn build and yarn lint-build

3a1f728

ghstack-source-id: 33b498f Pull Request resolved: #30071

Update

3b3a5c8

[ghstack-poisoned]

poteto added a commit that referenced this pull request Jun 24, 2024

[ci] Parallelize yarn build and yarn lint-build

b09d8ea

ghstack-source-id: 0767a1f Pull Request resolved: #30071

vercel bot deployed to Preview June 24, 2024 18:07 View deployment

Update

0fd3ef5

[ghstack-poisoned]

poteto added a commit that referenced this pull request Jun 24, 2024

[ci] Parallelize yarn build and yarn lint-build

c382ecc

ghstack-source-id: 2beffba Pull Request resolved: #30071

Update

9b90600

[ghstack-poisoned]

poteto added a commit that referenced this pull request Jun 24, 2024

[ci] Parallelize yarn build and yarn lint-build

c26ffdc

ghstack-source-id: fc61ba2 Pull Request resolved: #30071

vercel bot deployed to Preview June 24, 2024 18:15 View deployment

poteto mentioned this pull request Jun 24, 2024

[ci] Add yarn_test_build job to gh actions #30072

Merged

Update

d64589b

[ghstack-poisoned]

poteto mentioned this pull request Jun 24, 2024

[ci] Add process_artifacts_combined job #30073

Merged

vercel bot deployed to Preview June 24, 2024 21:16 View deployment

poteto added 3 commits June 24, 2024 17:23

Update

541d816

[ghstack-poisoned]

Update

01bd4ee

[ghstack-poisoned]

Update

04ee542

[ghstack-poisoned]

vercel bot deployed to Preview July 10, 2024 15:42 View deployment

Update

6fe929f

[ghstack-poisoned]

poteto changed the title ~~[ci] Parallelize yarn build and yarn lint-build~~ [ci] Parallelize yarn build Jul 10, 2024

vercel bot deployed to Preview July 10, 2024 16:09 View deployment

Update

736e128

[ghstack-poisoned]

vercel bot deployed to Preview July 10, 2024 16:26 View deployment

Update

1e09475

[ghstack-poisoned]

vercel bot deployed to Preview July 10, 2024 17:31 View deployment

Update

71e7cb4

[ghstack-poisoned]

vercel bot deployed to Preview July 10, 2024 18:52 View deployment

Update

d4edb3f

[ghstack-poisoned]

vercel bot deployed to Preview July 10, 2024 19:04 View deployment

poteto added a commit that referenced this pull request Jul 11, 2024

[ci] Parallelize yarn build

78f0dfe

ghstack-source-id: 78cf030 Pull Request resolved: #30071

Update

05a0efe

[ghstack-poisoned]

vercel bot deployed to Preview July 11, 2024 16:09 View deployment

poteto added a commit that referenced this pull request Jul 11, 2024

[ci] Parallelize yarn build

efd1890

ghstack-source-id: c93d81e Pull Request resolved: #30071

poteto added a commit that referenced this pull request Jul 11, 2024

[ci] Parallelize yarn build

69ee466

ghstack-source-id: c93d81e Pull Request resolved: #30071

poteto added a commit that referenced this pull request Jul 11, 2024

[ci] Parallelize yarn build

92262b5

ghstack-source-id: c93d81e Pull Request resolved: #30071

poteto added a commit that referenced this pull request Jul 12, 2024

[ci] Parallelize yarn build

bd58ce7

ghstack-source-id: c93d81e Pull Request resolved: #30071

Update

a52cbbc

[ghstack-poisoned]

poteto mentioned this pull request Jul 12, 2024

[RN] Remove __EXPERIMENTAL__ from enableOwnerStacks, enableUseDeferredValueInitialArg #30322

Merged

vercel bot deployed to Preview July 12, 2024 15:11 View deployment

poteto commented Jul 12, 2024

View reviewed changes

scripts/rollup/build-ghaction.js

Copy link

Member Author

poteto Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will unfork this later

jackpope reacted with thumbs up emoji

jackpope approved these changes Jul 12, 2024

View reviewed changes

poteto merged commit a52cbbc into gh/poteto/25/base Jul 12, 2024
181 checks passed

poteto added a commit that referenced this pull request Jul 12, 2024

[ci] Parallelize yarn build

3bc79cd

ghstack-source-id: 8a13b45 Pull Request resolved: #30071

poteto deleted the gh/poteto/25/head branch July 12, 2024 16:09

eps1lon mentioned this pull request Jul 16, 2024

Update React from dfd30974ab-20240613 to 01172397-20240716 vercel/next.js#67810

Closed

This was referenced Jul 25, 2024

Update React from 6230622a1a-20240610 to 76002254-20240724 vercel/next.js#68149

Merged

Update React from 6230622a1a-20240610 to 3208e73e-20240730 vercel/next.js#68330

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ci] Parallelize yarn build #30071

[ci] Parallelize yarn build #30071

Uh oh!

poteto commented Jun 24, 2024 •

edited

Loading

Uh oh!

vercel bot commented Jun 24, 2024 •

edited

Loading

Uh oh!

react-sizebot commented Jun 24, 2024 •

edited

Loading

Uh oh!

poteto Jul 12, 2024

Uh oh!

jackpope Jul 12, 2024

Uh oh!

poteto Jul 12, 2024

Uh oh!

jackpope Jul 12, 2024

Uh oh!

poteto Jul 12, 2024

Uh oh!

Uh oh!

Uh oh!

[ci] Parallelize yarn build #30071

[ci] Parallelize yarn build #30071

Uh oh!

Conversation

poteto commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

react-sizebot commented Jun 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Critical size changes

Significant size changes

Uh oh!

poteto Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

jackpope Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

poteto Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

jackpope Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

poteto Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

poteto commented Jun 24, 2024 •

edited

Loading

vercel bot commented Jun 24, 2024 •

edited

Loading

react-sizebot commented Jun 24, 2024 •

edited

Loading