Skip to content

Clean up enableUnifiedSyncLane flag #30062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2024
Merged

Clean up enableUnifiedSyncLane flag #30062

merged 3 commits into from
Jun 24, 2024

Conversation

jackpope
Copy link
Contributor

enableUnifiedSyncLane now passes everywhere. Let's clean it up

Implemented with #27646

Flag enabled with #27646, #28269, #29052

@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 3:09pm

@jackpope jackpope requested a review from tyao1 June 24, 2024 14:30
@jackpope jackpope requested a review from rickhanlonii June 24, 2024 14:30
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Jun 24, 2024
@react-sizebot
Copy link

react-sizebot commented Jun 24, 2024 •
edited
Loading

Comparing: 7608516...ce39de9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.93 kB 497.93 kB = 89.26 kB 89.25 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.84 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.75 kB 502.75 kB = 89.96 kB 89.96 kB
facebook-www/ReactDOM-prod.classic.js = 597.17 kB 596.94 kB = 105.33 kB 105.27 kB
facebook-www/ReactDOM-prod.modern.js = 571.52 kB 571.28 kB = 101.27 kB 101.21 kB
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 62.88 kB 0.00 kB Deleted 15.69 kB 0.00 kB

Generated by 🚫 dangerJS against ce39de9

@jackpope jackpope merged commit c21bcd6 into facebook:main Jun 24, 2024
@jackpope jackpope deleted the cleanup-unified-sync-lane-flag branch June 24, 2024 15:18
github-actions bot pushed a commit that referenced this pull request Jun 24, 2024
@jackpope
Clean up enableUnifiedSyncLane flag (#30062)
ae90e9f 
`enableUnifiedSyncLane` now passes everywhere. Let's clean it up

Implemented with #27646

Flag enabled with #27646,
#28269,
#29052

DiffTrain build for [c21bcd6](c21bcd6)
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

@tyao1 tyao1 Awaiting requested review from tyao1

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackpope @react-sizebot @kassens @facebook-github-bot