[compiler] Add pruned-scope terminal in HIR #29837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the HIR equivalent of a pruned-scope, allowing us to start porting the scope-pruning passes to operate on HIR. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: d172bda...2e39ef7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
mofeiZ
approved these changes
Jun 11, 2024
josephsavona
added a commit
that referenced
this pull request
Jun 11, 2024
Adds the HIR equivalent of a pruned-scope, allowing us to start porting the scope-pruning passes to operate on HIR. ghstack-source-id: dbbdc43219123467acc1a531d8276e8b9cc91e14 Pull Request resolved: #29837
TrickyPi
reviewed
Jun 12, 2024
| @@ -851,7 +851,8 @@ export function mapTerminalSuccessors( | |||
| loc: terminal.loc, | |||
| }; | |||
| } | |||
| case "scope": { | |||
| case "scope": | |||
| case "pruned-scope": { | |||
| const block = fn(terminal.block); | |||
| const fallthrough = fn(terminal.fallthrough); | |||
| return { | |||
There was a problem hiding this comment.
Hi @josephsavona, would it be appropriate to change the value of the return value's kind to terminal.kind?
https://github.com/facebook/react/pull/29837/files/2e39ef7c24a5155110929c19f918842972c58989#diff-8a37300261fbcd405210aeb6f21ea36db52abdc192b1215262ce2358f9bcc762L858
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds the HIR equivalent of a pruned-scope, allowing us to start porting the scope-pruning passes to operate on HIR.