Skip to content

compiler: repro for unmerged scopes due to intermediates #29197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2024
Merged

compiler: repro for unmerged scopes due to intermediates #29197

merged 2 commits into from
May 23, 2024

Conversation

@josephsavona
Copy link
Member

@josephsavona josephsavona commented May 21, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Repro of a case where we should ideally merge consecutive scopes, but where intermediate temporaries prevent the scopes from merging.

We'd need to reorder instructions in order to merge these.

@josephsavona
compiler: repro for unmerged scopes due to intermediates
a517ace 
Repro of a case where we should ideally merge consecutive scopes, but where intermediate temporaries prevent the scopes from merging.

We'd need to reorder instructions in order to merge these.

[ghstack-poisoned]
@josephsavona josephsavona mentioned this pull request May 21, 2024
Merged
@vercel
Copy link

vercel bot commented May 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 0:12am

This was referenced May 21, 2024
Merged
Merged
josephsavona added a commit that referenced this pull request May 21, 2024
@josephsavona
compiler: repro for unmerged scopes due to intermediates
bddd8dd 
Repro of a case where we should ideally merge consecutive scopes, but where intermediate temporaries prevent the scopes from merging.

We'd need to reorder instructions in order to merge these.

ghstack-source-id: d1139c6
Pull Request resolved: #29197
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label May 21, 2024
@react-sizebot
Copy link

react-sizebot commented May 21, 2024 •
edited
Loading

Comparing: bf046e8...919c68b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.71 kB 495.71 kB = 88.78 kB 88.78 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 500.51 kB 500.51 kB = 89.47 kB 89.47 kB
facebook-www/ReactDOM-prod.classic.js = 592.86 kB 592.86 kB = 104.28 kB 104.28 kB
facebook-www/ReactDOM-prod.modern.js = 569.08 kB 569.08 kB = 100.69 kB 100.69 kB
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.35 kB 0.00 kB Deleted 16.05 kB 0.00 kB

Generated by 🚫 dangerJS against 919c68b

@josephsavona
Update on "compiler: repro for unmerged scopes due to intermediates"
919c68b 
Repro of a case where we should ideally merge consecutive scopes, but where intermediate temporaries prevent the scopes from merging.

We'd need to reorder instructions in order to merge these.

[ghstack-poisoned]
josephsavona added a commit that referenced this pull request May 23, 2024
@josephsavona
compiler: repro for unmerged scopes due to intermediates
4313bf3 
Repro of a case where we should ideally merge consecutive scopes, but where intermediate temporaries prevent the scopes from merging.

We'd need to reorder instructions in order to merge these.

ghstack-source-id: 4f05672
Pull Request resolved: #29197
@josephsavona josephsavona merged commit 919c68b into gh/josephsavona/15/base May 23, 2024
josephsavona added a commit that referenced this pull request May 23, 2024
@josephsavona
compiler: repro for unmerged scopes due to intermediates
5fe8c0b 
Repro of a case where we should ideally merge consecutive scopes, but where intermediate temporaries prevent the scopes from merging.

We'd need to reorder instructions in order to merge these.

ghstack-source-id: 4f05672
Pull Request resolved: #29197
@josephsavona josephsavona deleted the gh/josephsavona/15/head branch May 23, 2024 16:45
@eps1lon eps1lon mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mofeiZ mofeiZ mofeiZ approved these changes

Assignees

No one assigned

Labels

CLA Signed Component: React Compiler React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@josephsavona @react-sizebot @mofeiZ @facebook-github-bot