Reconciler: Change commitUpdate signature to account for unused updatePayload parameter
#28909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: cf5ab8b...34fd689 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
force-pushed
the
cleanup-diffInCommit-unused-updatePayload
branch
2 times, most recently
from
3db92a6 to
2989591
Compare
eps1lon
commented
Apr 25, 2024
| // We may have an update on a Hoistable element | ||
| const updatePayload: null | UpdatePayload = | ||
| (finishedWork.updateQueue: any); | ||
| finishedWork.updateQueue = null; |
Collaborator
Author
There was a problem hiding this comment.
Confirmed by logging in yarn test that finishedWork.updateQueu is always null here
eps1lon
commented
Apr 25, 2024
| // TODO: Type the updateQueue to be specific to host components. | ||
| const updatePayload: null | UpdatePayload = | ||
| (finishedWork.updateQueue: any); | ||
| finishedWork.updateQueue = null; |
Collaborator
Author
There was a problem hiding this comment.
Confirmed by logging in yarn test that finishedWork.updateQueu is always null here
…datePayload` parameter
eps1lon
force-pushed
the
cleanup-diffInCommit-unused-updatePayload
branch
from
2989591 to
34fd689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diffInCommitPhaseis shipped (#27409) so we don't need to pass alongupdatePayloadwhich is alwaysnull.react-three-fiberwas bailing out if this payload wasnulland therefore never committed any update.By changing the signature the breakage becomes more obvious. The docs already document the proposed signature: https://github.com/facebook/react/blob/main/packages/react-reconciler/README.md#commitupdateinstance-type-prevprops-nextprops-internalhandle