Skip to content

Conversation

@jackpope
Copy link
Contributor

Let's get this into experimental to get more usage and allow other renderers to test against the changes easier.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 26, 2024
@react-sizebot
Copy link

react-sizebot commented Mar 26, 2024

Comparing: 95319ab...e329067

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.93 kB 176.93 kB = 54.95 kB 54.95 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 173.36 kB 173.33 kB = 54.08 kB 54.07 kB
facebook-www/ReactDOM-prod.classic.js = 595.27 kB 595.27 kB = 104.55 kB 104.55 kB
facebook-www/ReactDOM-prod.modern.js = 578.53 kB 578.53 kB = 101.57 kB 101.57 kB
oss-stable-semver/react-is/cjs/react-is.production.js +12.01% 6.62 kB 7.42 kB +7.82% 1.80 kB 1.94 kB
oss-stable/react-is/cjs/react-is.production.js +12.01% 6.62 kB 7.42 kB +7.82% 1.80 kB 1.94 kB
oss-stable-semver/react-is/cjs/react-is.development.js +11.96% 6.63 kB 7.43 kB +7.65% 1.84 kB 1.98 kB
oss-stable/react-is/cjs/react-is.development.js +11.96% 6.63 kB 7.43 kB +7.65% 1.84 kB 1.98 kB
oss-experimental/react-is/cjs/react-is.production.js +11.93% 6.65 kB 7.44 kB +7.97% 1.81 kB 1.95 kB
oss-experimental/react-is/cjs/react-is.development.js +11.88% 6.66 kB 7.45 kB +7.58% 1.85 kB 1.99 kB
oss-stable-semver/react-is/umd/react-is.development.js +11.33% 7.21 kB 8.03 kB +7.33% 1.94 kB 2.08 kB
oss-stable/react-is/umd/react-is.development.js +11.33% 7.21 kB 8.03 kB +7.33% 1.94 kB 2.08 kB
oss-experimental/react-is/umd/react-is.development.js +11.27% 7.23 kB 8.05 kB +7.26% 1.94 kB 2.08 kB
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-is/cjs/react-is.production.js +12.01% 6.62 kB 7.42 kB +7.82% 1.80 kB 1.94 kB
oss-stable/react-is/cjs/react-is.production.js +12.01% 6.62 kB 7.42 kB +7.82% 1.80 kB 1.94 kB
oss-stable-semver/react-is/cjs/react-is.development.js +11.96% 6.63 kB 7.43 kB +7.65% 1.84 kB 1.98 kB
oss-stable/react-is/cjs/react-is.development.js +11.96% 6.63 kB 7.43 kB +7.65% 1.84 kB 1.98 kB
oss-experimental/react-is/cjs/react-is.production.js +11.93% 6.65 kB 7.44 kB +7.97% 1.81 kB 1.95 kB
oss-experimental/react-is/cjs/react-is.development.js +11.88% 6.66 kB 7.45 kB +7.58% 1.85 kB 1.99 kB
oss-stable-semver/react-is/umd/react-is.development.js +11.33% 7.21 kB 8.03 kB +7.33% 1.94 kB 2.08 kB
oss-stable/react-is/umd/react-is.development.js +11.33% 7.21 kB 8.03 kB +7.33% 1.94 kB 2.08 kB
oss-experimental/react-is/umd/react-is.development.js +11.27% 7.23 kB 8.05 kB +7.26% 1.94 kB 2.08 kB
oss-stable-semver/react/cjs/react-jsx-dev-runtime.development.js +0.77% 40.76 kB 41.07 kB +0.68% 12.07 kB 12.16 kB
oss-stable/react/cjs/react-jsx-dev-runtime.development.js +0.77% 40.76 kB 41.07 kB +0.68% 12.07 kB 12.16 kB
oss-stable-semver/react/cjs/react-jsx-runtime.development.js +0.75% 41.99 kB 42.30 kB +0.67% 12.43 kB 12.51 kB
oss-stable/react/cjs/react-jsx-runtime.development.js +0.75% 41.99 kB 42.30 kB +0.67% 12.43 kB 12.51 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js +0.75% 42.06 kB 42.37 kB +0.64% 12.45 kB 12.53 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js +0.75% 42.06 kB 42.37 kB +0.64% 12.45 kB 12.53 kB
oss-experimental/react/cjs/react-jsx-dev-runtime.development.js +0.22% 41.38 kB 41.47 kB = 12.48 kB 12.48 kB
oss-experimental/react/cjs/react-jsx-runtime.development.js +0.22% 42.61 kB 42.70 kB = 12.82 kB 12.82 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js +0.22% 42.68 kB 42.77 kB = 12.84 kB 12.84 kB
oss-experimental/react-is/umd/react-is.production.min.js = 2.31 kB 2.31 kB +0.23% 0.86 kB 0.87 kB
oss-experimental/react-is/cjs/react-is.production.min.js = 2.24 kB 2.24 kB = 0.78 kB 0.78 kB
oss-experimental/react/umd/react.development.js = 124.05 kB 122.73 kB = 32.04 kB 31.84 kB
oss-experimental/react/cjs/react.development.js = 101.35 kB 100.14 kB = 27.42 kB 27.23 kB
test_utils/ReactAllWarnings.js Deleted 65.49 kB 0.00 kB Deleted 16.16 kB 0.00 kB

Generated by 🚫 dangerJS against e329067

Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaces: #28463

We should update the test renderer flags too, like I did in the above PR

@jackpope jackpope merged commit 738993d into facebook:main Mar 26, 2024
@jackpope jackpope deleted the renderable-context-experimental branch March 26, 2024 18:17
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Let's get this into experimental to get more usage and allow other
renderers to test against the changes easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants