Deprecate act from react-dom/test-utils in favor of act from react
#28597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
force-pushed
the
dom/test-utils-act-warning
branch
from
775df84 to
2803430
Compare
rickhanlonii
requested changes
Mar 23, 2024
| it('throws on every removed function with a special message', async () => { | ||
| expect(ReactTestUtils.isDOMComponent).toThrowError( | ||
| '`isDOMComponent` was removed from `react-dom/test-utils`. ' + | ||
| 'For testing React, we recommend React Testing Library instead: https://testing-library.com/docs/react-testing-library/intro.', |
Member
There was a problem hiding this comment.
Similar to the react-test-renderer warning, I don't think we should hard code the recommendations into the error message, instead something like:
isDOMComponentwas removed fromreact-dom/test-utils. See https://react.dev/warnings/react-test-renderer for more info.
Member
There was a problem hiding this comment.
Ditto for the other warning messages added here.
Member
There was a problem hiding this comment.
And we can update that warning page with info on which methods were removed, and why we removed them.
eps1lon
force-pushed
the
dom/test-utils-act-warning
branch
2 times, most recently
from
42124b8 to
eed0ea4
Compare
jackpope
approved these changes
Mar 27, 2024
eps1lon
force-pushed
the
dom/test-utils-act-warning
branch
from
eed0ea4 to
d9b56ba
Compare
eps1lon
force-pushed
the
dom/test-utils-act-warning
branch
from
d9b56ba to
32549cf
Compare
eps1lon
commented
Mar 27, 2024
eps1lon
force-pushed
the
dom/test-utils-act-warning
branch
from
db27415 to
32549cf
Compare
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #28541
Summary
Use
React.actinstead:How did you test this change?
React.actnow instead ofReactDOMTestUtilswhen testing the publicact