Better NEXT_MAJOR support for RN flags by rickhanlonii · Pull Request #28583 · facebook/react

rickhanlonii · 2024-03-19T00:31:06Z

The __NEXT_MAJOR__ value in the RN flags doesn't make sense because:

a) The flags are for the next RN major, since it only impacts the renderers
b) The flags are off, so they're not currently in the next major, they need enabled
c) the flag script didn't support it

This PR adds two aliases to the RN file:

__TODO_NEXT_RN_MAJOR__: flags that need enabled before the next RN major.
__NEXT_RN_MAJOR__: flags that have been enabled since the last RN major.

These values will need to be manually kept up to date when we cut a RN version, but once RN switches to the canary build and aligns all the flags, this entire file can be deleted.

Script screen

Notably, I added a TODO value and a legend that prints at the end of the script:

rickhanlonii · 2024-03-19T00:34:06Z

packages/shared/forks/ReactFeatureFlags.native-oss.js

+export const enableBinaryFlight = __NEXT_RN_MAJOR__; // DOM-only
+export const enableCustomElementPropertySupport = __NEXT_RN_MAJOR__; // DOM-only
+export const enableServerComponentKeys = __NEXT_RN_MAJOR__;
+export const enableServerComponentLogs = __NEXT_RN_MAJOR__;


@yungsters @rubennorte some of these likely went out in 0.74 right?

I know that enableCustomElementPropertySupport was enabled after the branch cut for 0.74, but I'm not sure about the other three.

fwiw there are 10 others in case you only saw the main page snippet

react-sizebot · 2024-03-19T00:35:41Z

Comparing: fa0efa1...7813b32

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.84 kB	176.84 kB	=	54.91 kB	54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.27 kB	173.27 kB	=	54.04 kB	54.04 kB
facebook-www/ReactDOM-prod.classic.js	=	594.30 kB	594.30 kB	=	104.45 kB	104.45 kB
facebook-www/ReactDOM-prod.modern.js	=	577.56 kB	577.56 kB	=	101.48 kB	101.48 kB
test_utils/ReactAllWarnings.js	Deleted	65.49 kB	0.00 kB	Deleted	16.16 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	65.49 kB	0.00 kB	Deleted	16.16 kB	0.00 kB

Generated by 🚫 dangerJS against 7813b32

packages/shared/forks/ReactFeatureFlags.native-oss.js

yungsters

So good. ❤️

The `__NEXT_MAJOR__` value in the RN flags doesn't make sense because: a) The flags are for the next RN major, since it only impacts the renderers b) The flags are off, so they're not currently in the next major, they need enabled c) the flag script didn't support it This PR adds two aliases to the RN file: - `__TODO_NEXT_RN_MAJOR__`: flags that need enabled before the next RN major. - `__NEXT_RN_MAJOR__`: flags that have been enabled since the last RN major. These values will need to be manually kept up to date when we cut a RN version, but once RN switches to the canary build and aligns all the flags, this entire file can be deleted. ## Script screen Notably, I added a TODO value and a legend that prints at the end of the script: <img width="1078" alt="Screenshot 2024-03-18 at 8 11 27 PM" src="https://github.com/facebook/react/assets/2440089/14da9066-f77d-437f-8188-830a31a843c5">

rickhanlonii requested review from kassens, rubennorte and yungsters March 19, 2024 00:31

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 19, 2024

rickhanlonii commented Mar 19, 2024

View reviewed changes

rubennorte reviewed Mar 19, 2024

View reviewed changes

packages/shared/forks/ReactFeatureFlags.native-oss.js Show resolved Hide resolved

yungsters approved these changes Mar 22, 2024

View reviewed changes

rickhanlonii added 2 commits March 22, 2024 12:45

Better NEXT_MAJOR support for RN flags

c4c5553

Add comment about flags ready to flip

64fb52d

rickhanlonii force-pushed the rh/rn-next-major branch from de45af0 to 3d8472e Compare March 22, 2024 16:45

Fix lint

7813b32

rickhanlonii force-pushed the rh/rn-next-major branch from 3d8472e to 7813b32 Compare March 22, 2024 16:49

rickhanlonii merged commit fabd6d3 into facebook:main Mar 22, 2024

rickhanlonii deleted the rh/rn-next-major branch March 22, 2024 17:02

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better NEXT_MAJOR support for RN flags#28583

Better NEXT_MAJOR support for RN flags#28583
rickhanlonii merged 3 commits intofacebook:mainfrom
rickhanlonii:rh/rn-next-major

rickhanlonii commented Mar 19, 2024

Uh oh!

rickhanlonii Mar 19, 2024

Uh oh!

yungsters Mar 19, 2024

Uh oh!

rickhanlonii Mar 19, 2024

Uh oh!

react-sizebot commented Mar 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

yungsters left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rickhanlonii commented Mar 19, 2024

Script screen

Uh oh!

rickhanlonii Mar 19, 2024

Choose a reason for hiding this comment

Uh oh!

yungsters Mar 19, 2024

Choose a reason for hiding this comment

Uh oh!

rickhanlonii Mar 19, 2024

Choose a reason for hiding this comment

Uh oh!

react-sizebot commented Mar 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Critical size changes

Significant size changes

Uh oh!

Uh oh!

yungsters left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

react-sizebot commented Mar 19, 2024 •

edited

Loading

yungsters left a comment •

edited

Loading