Add `alwaysThrottleDisappearingFallbacks` Flag by yungsters · Pull Request #28550 · facebook/react

yungsters · 2024-03-12T22:44:59Z

Summary

Creates a new alwaysThrottleDisappearingFallbacks feature flag that gates the changes from #26802 (instead of being controlled by alwaysThrottleRetries). The values of this new flag mirror the current values of alwaysThrottleRetries such that there is no behavior difference.

This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from alwaysThrottleRetries.

How did you test this change?

$ yarn test
$ yarn flow dom-browser
$ yarn flow dom-fb
$ yarn flow fabric

react-sizebot · 2024-03-12T22:48:56Z

Comparing: 7959a1d...2cb6843

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.83 kB	176.83 kB	=	54.90 kB	54.91 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	173.55 kB	173.55 kB	=	54.11 kB	54.11 kB
facebook-www/ReactDOM-prod.classic.js	+0.02%	594.16 kB	594.27 kB	+0.02%	104.41 kB	104.44 kB
facebook-www/ReactDOM-prod.modern.js	+0.02%	577.42 kB	577.53 kB	+0.02%	101.45 kB	101.47 kB
test_utils/ReactAllWarnings.js	Deleted	66.63 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.63 kB	0.00 kB	Deleted	16.28 kB	0.00 kB

Generated by 🚫 dangerJS against 2cb6843

rickhanlonii

Isn't it weird that no tests need updated?

rickhanlonii · 2024-03-18T16:20:49Z

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

 export const enableTransitionTracing = __VARIANT__;
 export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
 export const alwaysThrottleRetries = __VARIANT__;
+export const throttleDisappearingFallbacks = __VARIANT__;


I usually try to prefix the flag with enable so it's clear which direction the feature is going (always works too, as a mirror of the other flag)

yungsters · 2024-03-18T17:58:47Z

Isn't it weird that no tests need updated?

I assume that's because the feature flag is set to the same value as alwaysThrottleRetries for open source configurations.

## Summary Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that gates the changes from #26802 (instead of being controlled by `alwaysThrottleRetries`). The values of this new flag mirror the current values of `alwaysThrottleRetries` such that there is no behavior difference. This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from `alwaysThrottleRetries`. ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ``` DiffTrain build for [0aab065](0aab065)

## Summary After realizing that this feature flag is entangled with `alwaysThrottleRetries`, we're going to undo #28550 ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ```

## Summary After realizing that this feature flag is entangled with `alwaysThrottleRetries`, we're going to undo #28550 ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ``` DiffTrain build for [6fd0cb9](6fd0cb9)

## Summary Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that gates the changes from facebook#26802 (instead of being controlled by `alwaysThrottleRetries`). The values of this new flag mirror the current values of `alwaysThrottleRetries` such that there is no behavior difference. This additional feature flag allows us to incrementally validate the change (arguably bug fix) from facebook#26802 independently from `alwaysThrottleRetries`. ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ```

## Summary After realizing that this feature flag is entangled with `alwaysThrottleRetries`, we're going to undo facebook#28550 ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ```

## Summary Creates a new `alwaysThrottleDisappearingFallbacks` feature flag that gates the changes from #26802 (instead of being controlled by `alwaysThrottleRetries`). The values of this new flag mirror the current values of `alwaysThrottleRetries` such that there is no behavior difference. This additional feature flag allows us to incrementally validate the change (arguably bug fix) from #26802 independently from `alwaysThrottleRetries`. ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ``` DiffTrain build for commit 0aab065.

## Summary After realizing that this feature flag is entangled with `alwaysThrottleRetries`, we're going to undo facebook/react#28550 ## How did you test this change? ``` $ yarn test $ yarn flow dom-browser $ yarn flow dom-fb $ yarn flow fabric ``` DiffTrain build for commit facebook/react@6fd0cb9.

facebook-github-bot added the CLA Signed label Mar 12, 2024

yungsters force-pushed the throttle-disappear-fallbacks branch from 314e8b5 to 68226dc Compare March 13, 2024 22:30

rickhanlonii approved these changes Mar 18, 2024

View reviewed changes

yungsters force-pushed the throttle-disappear-fallbacks branch from 68226dc to 0c08bc6 Compare March 18, 2024 18:03

yungsters changed the title ~~Add throttleDisappearingFallbacks Flag~~ Add alwaysThrottleDisappearingFallbacks Flag Mar 18, 2024

Add alwaysThrottleDisappearingFallbacks Flag

2cb6843

yungsters force-pushed the throttle-disappear-fallbacks branch from 0c08bc6 to 2cb6843 Compare March 18, 2024 18:06

yungsters merged commit 0aab065 into facebook:main Mar 18, 2024

yungsters deleted the throttle-disappear-fallbacks branch March 18, 2024 18:16

ztanner mentioned this pull request Mar 21, 2024

Update React from 6c3b8dbfe to a4939017f vercel/next.js#63413

Closed

gnoff mentioned this pull request Mar 25, 2024

Update React from 14898b6a9 to e373190fa vercel/next.js#63685

Closed

yungsters mentioned this pull request Mar 25, 2024

Cleanup alwaysThrottleDisappearingFallbacks Flag #28639

Merged

eps1lon mentioned this pull request Apr 19, 2024

Update React from 14898b6a9 to c3048aab4 vercel/next.js#64798

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `alwaysThrottleDisappearingFallbacks` Flag#28550

Add `alwaysThrottleDisappearingFallbacks` Flag#28550
yungsters merged 1 commit intofacebook:mainfrom
yungsters:throttle-disappear-fallbacks

yungsters commented Mar 12, 2024 •

edited

Loading

Uh oh!

react-sizebot commented Mar 12, 2024 •

edited

Loading

Uh oh!

rickhanlonii left a comment

Uh oh!

rickhanlonii Mar 18, 2024

Uh oh!

yungsters commented Mar 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

yungsters commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How did you test this change?

Uh oh!

react-sizebot commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Critical size changes

Significant size changes

Uh oh!

rickhanlonii left a comment

Choose a reason for hiding this comment

Uh oh!

rickhanlonii Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

yungsters commented Mar 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yungsters commented Mar 12, 2024 •

edited

Loading

react-sizebot commented Mar 12, 2024 •

edited

Loading