Add script to output flag values #28115

rickhanlonii · 2024-01-26T19:09:26Z

Overview

Depends on: #28116

Add yarn flags to output at table of all feature flags.

Provides options to output a csv file, diff two or more builds, and sort.

Options

`yarn flags --diff next canary`

`yarn flags --diff canary experimental`

`yarn flags` (all flags)

react-sizebot · 2024-01-26T19:13:16Z

Comparing: af7e8c7...2ed4b03

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.67 kB	178.67 kB	=	55.63 kB	55.63 kB
facebook-www/ReactDOM-prod.classic.js	=	591.29 kB	591.29 kB	=	104.33 kB	104.33 kB
facebook-www/ReactDOM-prod.modern.js	=	575.05 kB	575.05 kB	=	101.42 kB	101.42 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against 2ed4b03

scripts/flags/flags.js

eps1lon · 2024-01-26T21:33:35Z

Love it. Does it make sense to sort flags alphanumerically? I could imagine it would help quickly scanning for a specific flag.

rickhanlonii · 2024-01-26T21:39:01Z

@eps1lon yeah, good idea. I'll follow up with that, I'm already on to another task that this stack is blocking

eps1lon

I'd also let it run in CI to catch breakages and give us a quick overview what flags are turned on where.

sammy-SC

this is super helpful, thanks!

rickhanlonii · 2024-01-30T22:57:23Z

scripts/flags/flags.js

+
+// Load ReactNativeFeatureFlags with __NEXT_MAJOR__ replace with 'next'.
+// We need to do string replace, since the __NEXT_MAJOR__ is assigned to __EXPERIMENTAL__.
+function getReactNativeFeatureFlagsMajor() {


I had to update the script since __NEXT_MAJOR__ is no longer a global. Since it's inline, we need to string replace the assignment in the module and virtually require the file.

## Overview Depends on: #28116 Add `yarn flags` to output at table of all feature flags. Provides options to output a csv file, diff two or more builds, and sort. ### Options <img width="1154" alt="Screenshot 2024-01-26 at 4 06 53 PM" src="https://github.com/facebook/react/assets/2440089/c3dbd632-adb9-4416-9488-1c603ee4e789"> ### `yarn flags --diff next canary` <img width="637" alt="Screenshot 2024-01-26 at 4 15 03 PM" src="https://github.com/facebook/react/assets/2440089/1a681ae8-ce33-42d0-9d1f-3f415a8e1c3d"> ### `yarn flags --diff canary experimental` <img width="637" alt="Screenshot 2024-01-26 at 4 14 51 PM" src="https://github.com/facebook/react/assets/2440089/c66f66cb-3cee-4df6-a1d1-b24600ebd4b3"> ### `yarn flags` (all flags) <img width="1054" alt="Screenshot 2024-01-26 at 4 16 30 PM" src="https://github.com/facebook/react/assets/2440089/4ce99c7c-825e-4bca-9b83-ca5d6e2bc1a9">

## Overview Depends on: facebook#28116 Add `yarn flags` to output at table of all feature flags. Provides options to output a csv file, diff two or more builds, and sort. ### Options <img width="1154" alt="Screenshot 2024-01-26 at 4 06 53 PM" src="https://github.com/facebook/react/assets/2440089/c3dbd632-adb9-4416-9488-1c603ee4e789"> ### `yarn flags --diff next canary` <img width="637" alt="Screenshot 2024-01-26 at 4 15 03 PM" src="https://github.com/facebook/react/assets/2440089/1a681ae8-ce33-42d0-9d1f-3f415a8e1c3d"> ### `yarn flags --diff canary experimental` <img width="637" alt="Screenshot 2024-01-26 at 4 14 51 PM" src="https://github.com/facebook/react/assets/2440089/c66f66cb-3cee-4df6-a1d1-b24600ebd4b3"> ### `yarn flags` (all flags) <img width="1054" alt="Screenshot 2024-01-26 at 4 16 30 PM" src="https://github.com/facebook/react/assets/2440089/4ce99c7c-825e-4bca-9b83-ca5d6e2bc1a9">

## Overview Depends on: #28116 Add `yarn flags` to output at table of all feature flags. Provides options to output a csv file, diff two or more builds, and sort. ### Options <img width="1154" alt="Screenshot 2024-01-26 at 4 06 53 PM" src="https://github.com/facebook/react/assets/2440089/c3dbd632-adb9-4416-9488-1c603ee4e789"> ### `yarn flags --diff next canary` <img width="637" alt="Screenshot 2024-01-26 at 4 15 03 PM" src="https://github.com/facebook/react/assets/2440089/1a681ae8-ce33-42d0-9d1f-3f415a8e1c3d"> ### `yarn flags --diff canary experimental` <img width="637" alt="Screenshot 2024-01-26 at 4 14 51 PM" src="https://github.com/facebook/react/assets/2440089/c66f66cb-3cee-4df6-a1d1-b24600ebd4b3"> ### `yarn flags` (all flags) <img width="1054" alt="Screenshot 2024-01-26 at 4 16 30 PM" src="https://github.com/facebook/react/assets/2440089/4ce99c7c-825e-4bca-9b83-ca5d6e2bc1a9"> DiffTrain build for commit 45582c6.

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 26, 2024

kassens reviewed Jan 26, 2024

View reviewed changes

scripts/flags/flags.js Outdated Show resolved Hide resolved

rickhanlonii force-pushed the rh/flag-script branch 3 times, most recently from c880229 to a492c28 Compare January 26, 2024 21:26

rickhanlonii marked this pull request as ready for review January 26, 2024 21:34

eps1lon approved these changes Jan 26, 2024

View reviewed changes

sammy-SC approved these changes Jan 29, 2024

View reviewed changes

rickhanlonii force-pushed the rh/flag-script branch from 5a9eb6c to 61f5aa8 Compare January 30, 2024 22:56

rickhanlonii commented Jan 30, 2024

View reviewed changes

flag script

d0d4b95

rickhanlonii force-pushed the rh/flag-script branch from 61f5aa8 to d0d4b95 Compare January 30, 2024 23:02

Add sorting by name

2ed4b03

rickhanlonii merged commit 45582c6 into facebook:main Jan 31, 2024
36 checks passed

rickhanlonii deleted the rh/flag-script branch January 31, 2024 04:16

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add script to output flag values #28115

Add script to output flag values #28115

rickhanlonii commented Jan 26, 2024 •

edited

Loading

react-sizebot commented Jan 26, 2024 •

edited

Loading

eps1lon commented Jan 26, 2024

rickhanlonii commented Jan 26, 2024

eps1lon left a comment

sammy-SC left a comment

rickhanlonii Jan 30, 2024

Add script to output flag values #28115

Add script to output flag values #28115

Conversation

rickhanlonii commented Jan 26, 2024 • edited Loading

Overview

Options

yarn flags --diff next canary

yarn flags --diff canary experimental

yarn flags (all flags)

react-sizebot commented Jan 26, 2024 • edited Loading

Critical size changes

Significant size changes

eps1lon commented Jan 26, 2024

rickhanlonii commented Jan 26, 2024

eps1lon left a comment

Choose a reason for hiding this comment

sammy-SC left a comment

Choose a reason for hiding this comment

rickhanlonii Jan 30, 2024

Choose a reason for hiding this comment

rickhanlonii commented Jan 26, 2024 •

edited

Loading

`yarn flags --diff next canary`

`yarn flags --diff canary experimental`

`yarn flags` (all flags)

react-sizebot commented Jan 26, 2024 •

edited

Loading