Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ReactPureComponent-test to createRoot #27917

Merged
merged 1 commit into from
Jan 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 46 additions & 17 deletions packages/react/src/__tests__/ReactPureComponent-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,20 @@

'use strict';

let act;

let React;
let ReactDOM;
let ReactDOMClient;

describe('ReactPureComponent', () => {
beforeEach(() => {
act = require('internal-test-utils').act;

React = require('react');
ReactDOM = require('react-dom');
ReactDOMClient = require('react-dom/client');
});

it('should render', () => {
it('should render', async () => {
let renders = 0;
class Component extends React.PureComponent {
constructor() {
Expand All @@ -32,36 +36,47 @@ describe('ReactPureComponent', () => {
}

const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
let text;
let component;
const componentRef = React.createRef();

text = ['porcini'];
component = ReactDOM.render(<Component text={text} />, container);
await act(() => {
root.render(<Component ref={componentRef} text={text} />);
});
expect(container.textContent).toBe('porcini');
expect(renders).toBe(1);

text = ['morel'];
component = ReactDOM.render(<Component text={text} />, container);
await act(() => {
root.render(<Component ref={componentRef} text={text} />);
});
expect(container.textContent).toBe('morel');
expect(renders).toBe(2);

text[0] = 'portobello';
component = ReactDOM.render(<Component text={text} />, container);
await act(() => {
root.render(<Component ref={componentRef} text={text} />);
});
expect(container.textContent).toBe('morel');
expect(renders).toBe(2);

// Setting state without changing it doesn't cause a rerender.
component.setState({type: 'mushrooms'});
await act(() => {
componentRef.current.setState({type: 'mushrooms'});
});
expect(container.textContent).toBe('morel');
expect(renders).toBe(2);

// But changing state does.
component.setState({type: 'portobello mushrooms'});
await act(() => {
componentRef.current.setState({type: 'portobello mushrooms'});
});
expect(container.textContent).toBe('portobello');
expect(renders).toBe(3);
});

it('can override shouldComponentUpdate', () => {
it('can override shouldComponentUpdate', async () => {
let renders = 0;
class Component extends React.PureComponent {
render() {
Expand All @@ -74,17 +89,24 @@ describe('ReactPureComponent', () => {
}

const container = document.createElement('div');
expect(() => ReactDOM.render(<Component />, container)).toErrorDev(
const root = ReactDOMClient.createRoot(container);
await expect(async () => {
await act(() => {
root.render(<Component />);
});
}).toErrorDev(
'Warning: ' +
'Component has a method called shouldComponentUpdate(). ' +
'shouldComponentUpdate should not be used when extending React.PureComponent. ' +
'Please extend React.Component if shouldComponentUpdate is used.',
);
ReactDOM.render(<Component />, container);
await act(() => {
root.render(<Component />);
});
expect(renders).toBe(2);
});

it('extends React.Component', () => {
it('extends React.Component', async () => {
let renders = 0;
class Component extends React.PureComponent {
render() {
Expand All @@ -94,11 +116,14 @@ describe('ReactPureComponent', () => {
return <div />;
}
}
ReactDOM.render(<Component />, document.createElement('div'));
const root = ReactDOMClient.createRoot(document.createElement('div'));
await act(() => {
root.render(<Component />);
});
expect(renders).toBe(1);
});

it('should warn when shouldComponentUpdate is defined on React.PureComponent', () => {
it('should warn when shouldComponentUpdate is defined on React.PureComponent', async () => {
class PureComponent extends React.PureComponent {
shouldComponentUpdate() {
return true;
Expand All @@ -107,8 +132,12 @@ describe('ReactPureComponent', () => {
return <div />;
}
}
const container = document.createElement('div');
expect(() => ReactDOM.render(<PureComponent />, container)).toErrorDev(
const root = ReactDOMClient.createRoot(document.createElement('div'));
await expect(async () => {
await act(() => {
root.render(<PureComponent />);
});
}).toErrorDev(
'Warning: ' +
'PureComponent has a method called shouldComponentUpdate(). ' +
'shouldComponentUpdate should not be used when extending React.PureComponent. ' +
Expand Down