Build: use content hash for facebook-react-native build #27577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 960ed6e...f5a2de5 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
hoxyq
approved these changes
Oct 25, 2023
Comment on lines
+359
to
+366
| function hashJSFilesInDirectory(directory) { | ||
| const hash = crypto.createHash('sha1'); | ||
| for (const filePath of glob.sync(directory + '/**/*.js').sort()) { | ||
| hash.update(fs.readFileSync(filePath)); | ||
| } | ||
| return hash.digest('hex').slice(0, 8); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we hash based on only JS files? Not important now, but hashing on non-directories seems more reliable, in case we will distribute non-js files at some point
There was a problem hiding this comment.
I'm actually not sure if we even need this version string anyway? I think devtools use them in some capacity, but I'm not sure what the exact requirements are.
nice! thanks for doing this |
kassens
added a commit
that referenced
this pull request
Oct 25, 2023
…)" This reverts commit 51ffd35.
kassens
added a commit
that referenced
this pull request
Oct 25, 2023
) Reverts #27577. We also sync React Native OSS bundles which means this didn't work as hoped unless we abandon the commit hash in OSS which seems useful.
gnoff
added a commit
to gnoff/next.js
that referenced
this pull request
Oct 25, 2023
gnoff
added a commit
to gnoff/next.js
that referenced
this pull request
Oct 25, 2023
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 25, 2023
React upstream changes: - facebook/react#27586 - facebook/react#27577 - facebook/react#27576 Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this pull request
Jan 5, 2024
…584) Reverts facebook/react#27577. We also sync React Native OSS bundles which means this didn't work as hoped unless we abandon the commit hash in OSS which seems useful. DiffTrain build for [97047a810cb19e3041a3ec163f4fde85f495bdc1](facebook/react@97047a8)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Similar to facebook#26734, this switches the RN builds for Meta to a content hash instead of git commit number to make the builds reproducible and avoid creating sync commits if the bundled content didn't change.
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…ebook#27584) Reverts facebook#27577. We also sync React Native OSS bundles which means this didn't work as hoped unless we abandon the commit hash in OSS which seems useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #26734, this switches the RN builds for Meta to a content hash instead of git commit number to make the builds reproducible and avoid creating sync commits if the bundled content didn't change.