Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix: Detect infinite update loops caused by render phase updates (#26625)" #27027

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Revert "Fix: Detect infinite update loops caused by render phase updates (#26625)" #27027

merged 1 commit into from
Jun 30, 2023

Conversation

kassens
Copy link
Member

@kassens kassens commented Jun 30, 2023

This reverts commit 822386f.

This broke a number of tests when synced internally. We'll need to investigate the breakages before relanding this.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 30, 2023
rickhanlonii
rickhanlonii approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also broke prod in RN, and the PR changes weren't reviewed after the PR was re-written.

@kassens kassens merged commit 7f362de into facebook:main Jun 30, 2023
@kassens kassens deleted the backout-rerender-warning branch June 30, 2023 16:51
@react-sizebot
Copy link

Comparing: fc80111...dc599d4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.51 kB 164.22 kB = 51.85 kB 51.74 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.93 kB 171.63 kB = 54.06 kB 53.95 kB
facebook-www/ReactDOM-prod.classic.js = 568.63 kB 566.78 kB = 100.25 kB 99.97 kB
facebook-www/ReactDOM-prod.modern.js = 552.43 kB 550.58 kB = 97.41 kB 97.13 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-art/umd/react-art.production.min.js = 135.74 kB 135.45 kB = 42.42 kB 42.28 kB
oss-stable/react-art/umd/react-art.production.min.js = 131.93 kB 131.64 kB = 41.33 kB 41.17 kB
oss-stable-semver/react-art/umd/react-art.production.min.js = 131.88 kB 131.59 kB = 41.30 kB 41.14 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js = 124.07 kB 123.78 kB = 37.37 kB 37.26 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js = 119.87 kB 119.58 kB = 36.12 kB 36.01 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js = 119.85 kB 119.55 kB = 36.10 kB 35.99 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 115.05 kB 114.75 kB = 35.19 kB 35.05 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js = 110.85 kB 110.56 kB = 33.93 kB 33.79 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js = 110.83 kB 110.53 kB = 33.91 kB 33.77 kB
oss-experimental/react-art/cjs/react-art.production.min.js = 98.48 kB 98.18 kB = 30.27 kB 30.15 kB
facebook-www/ReactDOM-profiling.classic.js = 599.17 kB 597.32 kB = 104.78 kB 104.46 kB
oss-stable/react-art/cjs/react-art.production.min.js = 94.65 kB 94.35 kB = 29.16 kB 29.04 kB
oss-stable-semver/react-art/cjs/react-art.production.min.js = 94.60 kB 94.30 kB = 29.13 kB 29.01 kB
facebook-www/ReactDOMTesting-prod.classic.js = 583.44 kB 581.60 kB = 103.95 kB 103.68 kB
facebook-www/ReactDOM-profiling.modern.js = 582.89 kB 581.05 kB = 101.94 kB 101.62 kB
facebook-www/ReactDOMTesting-prod.modern.js = 568.97 kB 567.12 kB = 101.50 kB 101.23 kB
facebook-www/ReactDOM-prod.classic.js = 568.63 kB 566.78 kB = 100.25 kB 99.97 kB
facebook-www/ReactDOM-prod.modern.js = 552.43 kB 550.58 kB = 97.41 kB 97.13 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,454.15 kB 1,448.65 kB = 314.97 kB 313.46 kB
facebook-www/ReactDOM-dev.classic.js = 1,435.80 kB 1,430.30 kB = 310.55 kB 308.98 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,426.25 kB 1,420.75 kB = 309.42 kB 307.87 kB
facebook-www/ReactDOM-dev.modern.js = 1,407.91 kB 1,402.41 kB = 304.99 kB 303.45 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,374.76 kB 1,369.30 kB = 293.89 kB 292.42 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,329.53 kB 1,324.23 kB = 295.31 kB 293.81 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 1,311.47 kB 1,306.18 kB = 290.95 kB 289.49 kB
oss-stable/react-dom/umd/react-dom.development.js = 1,328.45 kB 1,322.99 kB = 284.35 kB 282.88 kB
oss-stable-semver/react-dom/umd/react-dom.development.js = 1,328.43 kB 1,322.96 kB = 284.33 kB 282.85 kB
oss-stable/react-dom/cjs/react-dom.development.js = 1,267.23 kB 1,261.93 kB = 281.32 kB 279.87 kB
oss-stable-semver/react-dom/cjs/react-dom.development.js = 1,267.20 kB 1,261.91 kB = 281.29 kB 279.84 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js = 104.06 kB 103.57 kB = 32.37 kB 32.16 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js = 104.01 kB 103.52 kB = 32.34 kB 32.14 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 104.19 kB 103.69 kB = 32.41 kB 32.21 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 103.80 kB 103.30 kB = 32.01 kB 31.77 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js = 103.68 kB 103.18 kB = 31.97 kB 31.73 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js = 103.63 kB 103.13 kB = 31.94 kB 31.71 kB
facebook-www/ReactART-prod.classic.js = 347.69 kB 345.92 kB = 59.19 kB 58.90 kB
facebook-www/ReactART-prod.modern.js = 336.69 kB 334.93 kB = 57.28 kB 56.99 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 363.63 kB 361.66 kB = 64.11 kB 63.74 kB
react-native/implementations/ReactFabric-profiling.fb.js = 354.80 kB 352.84 kB = 62.37 kB 62.00 kB
react-native/implementations/ReactNativeRenderer-profiling.js = 349.17 kB 347.20 kB = 61.62 kB 61.28 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 926.62 kB 921.32 kB = 198.98 kB 197.50 kB
oss-experimental/react-art/umd/react-art.development.js = 944.56 kB 939.09 kB = 200.10 kB 198.63 kB
react-native/implementations/ReactFabric-profiling.js = 340.22 kB 338.25 kB = 59.86 kB 59.51 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 336.25 kB 334.28 kB = 59.82 kB 59.47 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 903.14 kB 897.84 kB = 194.24 kB 192.78 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 903.12 kB 897.82 kB = 194.21 kB 192.74 kB
oss-stable/react-art/umd/react-art.development.js = 921.49 kB 916.02 kB = 195.80 kB 194.30 kB
oss-stable-semver/react-art/umd/react-art.development.js = 921.46 kB 916.00 kB = 195.77 kB 194.27 kB
react-native/implementations/ReactNativeRenderer-prod.js = 329.63 kB 327.66 kB = 58.38 kB 58.02 kB
facebook-www/ReactART-dev.classic.js = 917.71 kB 912.21 kB = 195.95 kB 194.46 kB
react-native/implementations/ReactFabric-prod.fb.js = 327.41 kB 325.44 kB = 58.10 kB 57.76 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 907.10 kB 901.60 kB = 197.89 kB 196.37 kB
facebook-www/ReactART-dev.modern.js = 906.50 kB 901.00 kB = 193.64 kB 192.17 kB
react-native/implementations/ReactFabric-prod.js = 320.68 kB 318.71 kB = 56.64 kB 56.28 kB
react-native/implementations/ReactFabric-dev.fb.js = 891.44 kB 885.94 kB = 193.44 kB 191.91 kB
react-native/implementations/ReactNativeRenderer-dev.js = 880.52 kB 875.03 kB = 193.16 kB 191.64 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 314.81 kB 312.84 kB = 55.69 kB 55.29 kB
react-native/implementations/ReactFabric-dev.js = 864.87 kB 859.37 kB = 188.82 kB 187.28 kB
oss-experimental/react-art/cjs/react-art.development.js = 828.58 kB 823.28 kB = 181.06 kB 179.59 kB
oss-stable/react-art/cjs/react-art.development.js = 806.60 kB 801.30 kB = 176.69 kB 175.23 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 806.57 kB 801.27 kB = 176.66 kB 175.21 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 298.96 kB 296.99 kB = 53.24 kB 52.89 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 825.66 kB 820.20 kB = 174.92 kB 173.43 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js = 825.27 kB 819.81 kB = 174.82 kB 173.33 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js = 825.25 kB 819.78 kB = 174.80 kB 173.30 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 788.34 kB 783.05 kB = 173.09 kB 171.63 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 787.98 kB 782.68 kB = 173.01 kB 171.55 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 787.95 kB 782.65 kB = 172.98 kB 171.52 kB
facebook-www/ReactTestRenderer-dev.classic.js = 806.40 kB 800.90 kB = 175.18 kB 173.67 kB
facebook-www/ReactTestRenderer-dev.modern.js = 806.40 kB 800.90 kB = 175.18 kB 173.67 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 800.09 kB 794.60 kB = 174.36 kB 172.85 kB

Generated by 🚫 dangerJS against dc599d4

github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
@kassens
Revert "Fix: Detect infinite update loops caused by render phase upda…
023fffc 
…tes (#26625)" (#27027)

This reverts commit 822386f.

This broke a number of tests when synced internally. We'll need to
investigate the breakages before relanding this.

DiffTrain build for [7f362de](7f362de)
@styfle styfle mentioned this pull request Jun 30, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Jul 4, 2023
@styfle @shuding
chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 (#52005)
9e4b87d 
This PR updates the vendored react dependencies using `pnpm sync-react`

### React upstream changes

- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

### Related

Closes #49409 (by facebook/react#26977)
fix NEXT-1189

Co-authored-by: Shu Ding <g@shud.in>
@styfle styfle mentioned this pull request Jul 5, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Jul 6, 2023
@styfle @huozhi
chore(deps): bump react to 7118f5dd7 (#52282)
6dafc42 
Fixes #49409

### React upstream changes

- facebook/react#27045
- facebook/react#27051
- facebook/react#27032
- facebook/react#27031
- facebook/react#27029
- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

---------

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
shuding added a commit to vercel/next.js that referenced this pull request Jul 8, 2023
@styfle @shuding
chore(deps): bump react 18.3.0-canary-1fdacbefd-20230630 (#52005)
1ae3f42 
This PR updates the vendored react dependencies using `pnpm sync-react`

### React upstream changes

- facebook/react#27028
- facebook/react#27027
- facebook/react#27019
- facebook/react#26954
- facebook/react#26987
- facebook/react#26985
- facebook/react#26933
- facebook/react#26625
- facebook/react#27011
- facebook/react#27008
- facebook/react#26997
- facebook/react#26989
- facebook/react#26955
- facebook/react#26963
- facebook/react#26983
- facebook/react#26914
- facebook/react#26951
- facebook/react#26977
- facebook/react#26958
- facebook/react#26940
- facebook/react#26939
- facebook/react#26887
- facebook/react#26947
- facebook/react#26945
- facebook/react#26942
- facebook/react#26938
- facebook/react#26844
- facebook/react#25510
- facebook/react#26932
- facebook/react#26896
- facebook/react#26913
- facebook/react#26888
- facebook/react#26827
- facebook/react#26889
- facebook/react#26877
- facebook/react#26873
- facebook/react#26880
- facebook/react#26842
- facebook/react#26858
- facebook/react#26754
- facebook/react#26753
- facebook/react#26881

### Related

Closes #49409 (by facebook/react#26977)
fix NEXT-1189

Co-authored-by: Shu Ding <g@shud.in>
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@kassens @AndyPengc12
Revert "Fix: Detect infinite update loops caused by render phase upda…
40f9658 
…tes (facebook#26625)" (facebook#27027)

This reverts commit 822386f.

This broke a number of tests when synced internally. We'll need to
investigate the breakages before relanding this.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@kassens
Revert "Fix: Detect infinite update loops caused by render phase upda…
b2dc5de 
…tes (#26625)" (#27027)

This reverts commit 822386f.

This broke a number of tests when synced internally. We'll need to
investigate the breakages before relanding this.

DiffTrain build for commit 7f362de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kassens @react-sizebot @rickhanlonii @facebook-github-bot