[react devtools] Device storage support #25452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getValue(string)andsetValue(string, string), and are thin wrappers around theLibrary/Settingsturbomodule.connectToDevtools. The setters are then used to populate values onwindow. Later, the console is patched using these values.connectToDevToolsreact-native#34903How did you test this change?
Manual testing,
yarn run test-build-devtools,yarn run prettier,yarn run flow domManual testing setup:
React DevTools Frontend
nvm install -g react-devtools-core, then replace that package with a symlink to the local packageReact DevTools Backend
yarn run build:backendin react-devtools-core, then copy-paste that file to the expo app's node_modules directoryReact Native
"react-native": "rbalicki2/react-native#branch-name"Versioning safety
cachedSettingsStoreis passed from react native. If not (e.g. if React Native is outdated), then no behavior changes.