Skip to content

Conversation

kassens
Copy link
Member

@kassens kassens commented Oct 4, 2022

Stack from ghstack (oldest at bottom):

This version banned use of this in object functions.

This version banned use of this in object functions.

[ghstack-poisoned]
kassens added a commit that referenced this pull request Oct 4, 2022
This version banned use of this in object functions.

ghstack-source-id: 6c1e711
Pull Request resolved: #25414
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 4, 2022
@sizebot
Copy link

sizebot commented Oct 4, 2022

Comparing: 9f8a98a...a4f42f2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.41 kB 43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.72 kB 147.72 kB = 47.17 kB 47.17 kB
facebook-www/ReactDOM-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.24 kB 85.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.70 kB 491.70 kB = 87.49 kB 87.49 kB
oss-experimental/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-stable-semver/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-stable/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-experimental/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-stable-semver/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-stable/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-stable-semver/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-stable/react-fetch/cjs/react-fetch.browser.development.js +17.85% 3.43 kB 4.04 kB +5.44% 1.16 kB 1.22 kB
oss-experimental/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-stable-semver/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-stable/react-fetch/cjs/react-fetch.node.development.js +11.68% 5.09 kB 5.69 kB +3.50% 1.63 kB 1.69 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js +0.57% 5.64 kB 5.67 kB +1.49% 1.81 kB 1.84 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js +0.57% 5.64 kB 5.67 kB +1.49% 1.81 kB 1.84 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-with-selector.development.js +0.57% 5.64 kB 5.67 kB +1.49% 1.81 kB 1.84 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js +0.56% 5.70 kB 5.73 kB +1.37% 1.83 kB 1.85 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js +0.56% 5.70 kB 5.73 kB +1.37% 1.83 kB 1.85 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim/with-selector.development.js +0.56% 5.70 kB 5.73 kB +1.37% 1.83 kB 1.85 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js +0.41% 7.83 kB 7.87 kB +0.84% 3.09 kB 3.11 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js +0.41% 7.83 kB 7.87 kB +0.84% 3.09 kB 3.11 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.native.development.js +0.41% 7.83 kB 7.87 kB +0.84% 3.09 kB 3.11 kB
oss-experimental/use-sync-external-store/cjs/use-sync-external-store-shim.development.js +0.38% 8.42 kB 8.45 kB +0.82% 3.19 kB 3.21 kB
oss-stable-semver/use-sync-external-store/cjs/use-sync-external-store-shim.development.js +0.38% 8.42 kB 8.45 kB +0.82% 3.19 kB 3.21 kB
oss-stable/use-sync-external-store/cjs/use-sync-external-store-shim.development.js +0.38% 8.42 kB 8.45 kB +0.82% 3.19 kB 3.21 kB

Generated by 🚫 dangerJS against a4f42f2

This version banned use of this in object functions.

[ghstack-poisoned]
kassens added a commit that referenced this pull request Oct 4, 2022
This version banned use of this in object functions.

ghstack-source-id: f49fd5e
Pull Request resolved: #25414
@kassens kassens merged commit a4f42f2 into gh/kassens/4/base Oct 4, 2022
kassens added a commit that referenced this pull request Oct 4, 2022
This version banned use of this in object functions.

ghstack-source-id: f49fd5e
Pull Request resolved: #25414
@kassens kassens deleted the gh/kassens/4/head branch October 4, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants