Add RulesOfHooks support for use
#25370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
This was referenced Sep 30, 2022
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 338e6a9...27e5f3e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
Usage of the new `use` hook needs to conform to the rules of hooks, with the one exception that it can be called conditionally. [ghstack-poisoned]
acdlite
approved these changes
Oct 4, 2022
Collaborator
acdlite
left a comment
acdlite
left a comment
There was a problem hiding this comment.
Yay! I don't know the linter codebase very well but the behavior looks correct to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
use#25370Usage of the new
usehook needs to conform to the rules of hooks, withthe one exception that it can be called conditionally.