Skip to content

Add detach to Offscreen component #25265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 18, 2022
Merged

Add detach to Offscreen component #25265

merged 17 commits into from
Oct 18, 2022

Conversation

sammy-SC
Copy link
Contributor

@sammy-SC sammy-SC commented Sep 14, 2022 •
edited
Loading

This is built on top of #25254

This PR adds detach method to Offscreen.

@sammy-SC sammy-SC requested review from acdlite and rickhanlonii and removed request for acdlite September 14, 2022 13:10
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 14, 2022
@sizebot
Copy link

sizebot commented Sep 14, 2022 •
edited
Loading

Comparing: a6bf466...eed79b5

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.24% 135.64 kB 135.97 kB +0.17% 43.46 kB 43.53 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.22% 149.89 kB 150.22 kB +0.17% 47.87 kB 47.95 kB
facebook-www/ReactDOM-prod.classic.js +0.21% 492.27 kB 493.30 kB +0.20% 87.58 kB 87.76 kB
facebook-www/ReactDOM-prod.modern.js +0.22% 477.52 kB 478.56 kB +0.23% 85.38 kB 85.58 kB
facebook-www/ReactDOMForked-prod.classic.js +0.21% 492.27 kB 493.30 kB +0.20% 87.58 kB 87.76 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-test-renderer/umd/react-test-renderer.production.min.js +0.49% 93.00 kB 93.45 kB +0.40% 29.02 kB 29.13 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js +0.49% 93.02 kB 93.48 kB +0.40% 29.02 kB 29.13 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.min.js +0.49% 92.75 kB 93.21 kB +0.36% 28.56 kB 28.67 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js +0.49% 92.78 kB 93.23 kB +0.36% 28.56 kB 28.67 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js +0.46% 97.45 kB 97.91 kB +0.34% 29.89 kB 29.99 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js +0.46% 97.69 kB 98.15 kB +0.34% 30.32 kB 30.43 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.min.js +0.40% 97.01 kB 97.39 kB +0.35% 29.82 kB 29.92 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js +0.40% 97.03 kB 97.42 kB +0.34% 29.84 kB 29.94 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.min.js +0.38% 105.83 kB 106.23 kB +0.31% 32.02 kB 32.12 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +0.38% 105.86 kB 106.25 kB +0.31% 32.04 kB 32.14 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js +0.37% 105.66 kB 106.05 kB +0.33% 32.30 kB 32.41 kB
react-native/implementations/ReactFabric-prod.fb.js +0.36% 318.17 kB 319.33 kB +0.34% 56.50 kB 56.70 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js +0.35% 114.52 kB 114.91 kB +0.30% 34.47 kB 34.57 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.35% 344.83 kB 346.02 kB +0.33% 60.62 kB 60.82 kB
oss-stable-semver/react-art/cjs/react-art.production.min.js +0.33% 85.42 kB 85.70 kB +0.27% 26.49 kB 26.57 kB
oss-stable/react-art/cjs/react-art.production.min.js +0.33% 85.44 kB 85.72 kB +0.26% 26.50 kB 26.57 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js +0.32% 324.99 kB 326.03 kB +0.31% 57.58 kB 57.75 kB
oss-experimental/react-art/cjs/react-art.production.min.js +0.31% 92.06 kB 92.35 kB +0.23% 28.34 kB 28.40 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.31% 351.72 kB 352.79 kB +0.31% 61.72 kB 61.91 kB
react-native/implementations/ReactFabric-prod.js +0.29% 309.10 kB 310.00 kB +0.35% 54.74 kB 54.93 kB
react-native/implementations/ReactFabric-profiling.js +0.29% 328.18 kB 329.13 kB +0.36% 57.87 kB 58.08 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.28% 281.40 kB 282.19 kB +0.29% 49.96 kB 50.11 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.28% 296.98 kB 297.81 kB +0.31% 52.32 kB 52.49 kB
facebook-www/ReactART-prod.modern.js +0.27% 319.26 kB 320.13 kB +0.31% 54.55 kB 54.72 kB
facebook-www/ReactART-prod.classic.js +0.27% 330.06 kB 330.93 kB +0.31% 56.34 kB 56.52 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.25% 315.91 kB 316.70 kB +0.34% 55.81 kB 56.00 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.25% 335.08 kB 335.91 kB +0.30% 58.94 kB 59.11 kB
oss-stable-semver/react-dom/cjs/react-dom.production.min.js +0.24% 135.62 kB 135.95 kB +0.17% 43.46 kB 43.53 kB
oss-stable/react-dom/cjs/react-dom.production.min.js +0.24% 135.64 kB 135.97 kB +0.17% 43.46 kB 43.53 kB
oss-stable-semver/react-dom/umd/react-dom.profiling.min.js +0.24% 144.54 kB 144.88 kB +0.17% 46.38 kB 46.46 kB
oss-stable/react-dom/umd/react-dom.profiling.min.js +0.24% 144.56 kB 144.90 kB +0.17% 46.38 kB 46.46 kB
oss-stable-semver/react-dom/cjs/react-dom.profiling.min.js +0.24% 145.09 kB 145.43 kB +0.19% 45.87 kB 45.96 kB
oss-stable/react-dom/cjs/react-dom.profiling.min.js +0.23% 145.11 kB 145.46 kB +0.19% 45.87 kB 45.96 kB
oss-stable-semver/react-dom/umd/react-dom.production.min.js +0.23% 135.73 kB 136.05 kB +0.32% 44.10 kB 44.24 kB
oss-stable/react-dom/umd/react-dom.production.min.js +0.23% 135.76 kB 136.07 kB +0.32% 44.09 kB 44.23 kB
oss-stable-semver/react-art/umd/react-art.production.min.js +0.23% 121.30 kB 121.58 kB +0.14% 37.70 kB 37.75 kB
oss-stable/react-art/umd/react-art.production.min.js +0.23% 121.33 kB 121.61 kB +0.14% 37.70 kB 37.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js +0.23% 146.76 kB 147.09 kB +0.17% 47.24 kB 47.33 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.22% 149.89 kB 150.22 kB +0.17% 47.87 kB 47.95 kB
oss-experimental/react-art/umd/react-art.production.min.js +0.22% 127.91 kB 128.19 kB +0.15% 39.65 kB 39.71 kB
facebook-www/ReactDOM-prod.modern.js +0.22% 477.52 kB 478.56 kB +0.23% 85.38 kB 85.58 kB
facebook-www/ReactDOMForked-prod.modern.js +0.22% 477.52 kB 478.56 kB +0.23% 85.38 kB 85.58 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js +0.21% 159.37 kB 159.71 kB +0.18% 50.36 kB 50.45 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.21% 692.29 kB 693.78 kB +0.25% 150.31 kB 150.69 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.21% 692.31 kB 693.80 kB +0.25% 150.33 kB 150.71 kB
oss-stable-semver/react-test-renderer/umd/react-test-renderer.development.js +0.21% 725.12 kB 726.67 kB +0.28% 151.87 kB 152.30 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js +0.21% 725.14 kB 726.69 kB +0.28% 151.89 kB 152.32 kB
facebook-www/ReactDOM-profiling.modern.js +0.21% 507.39 kB 508.47 kB +0.20% 89.90 kB 90.08 kB
facebook-www/ReactDOMForked-profiling.modern.js +0.21% 507.39 kB 508.47 kB +0.20% 89.90 kB 90.08 kB
oss-experimental/react-dom/umd/react-dom.production.min.js +0.21% 149.91 kB 150.23 kB +0.16% 48.52 kB 48.60 kB
react-native/implementations/ReactFabric-dev.fb.js +0.21% 854.29 kB 856.10 kB +0.33% 183.88 kB 184.47 kB
react-native/implementations/ReactFabric-dev.js +0.21% 813.09 kB 814.81 kB +0.33% 176.29 kB 176.87 kB
facebook-www/ReactDOM-prod.classic.js +0.21% 492.27 kB 493.30 kB +0.20% 87.58 kB 87.76 kB
facebook-www/ReactDOMForked-prod.classic.js +0.21% 492.27 kB 493.30 kB +0.20% 87.58 kB 87.76 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.21% 734.74 kB 736.29 kB +0.25% 157.53 kB 157.92 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.21% 719.39 kB 720.88 kB +0.25% 155.11 kB 155.49 kB
oss-stable/react-art/cjs/react-art.development.js +0.21% 719.42 kB 720.90 kB +0.25% 155.13 kB 155.51 kB
facebook-www/ReactDOM-profiling.classic.js +0.21% 522.20 kB 523.28 kB +0.18% 92.21 kB 92.37 kB
facebook-www/ReactDOMForked-profiling.classic.js +0.21% 522.20 kB 523.28 kB +0.18% 92.21 kB 92.37 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.21% 720.73 kB 722.22 kB +0.24% 156.06 kB 156.43 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js +0.21% 755.01 kB 756.56 kB +0.24% 157.69 kB 158.07 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js +0.20% 158.73 kB 159.06 kB +0.10% 50.81 kB 50.86 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.20% 756.79 kB 758.33 kB +0.25% 161.63 kB 162.02 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.20% 756.79 kB 758.33 kB +0.24% 161.63 kB 162.02 kB

Generated by 🚫 dangerJS against eed79b5

@sammy-SC sammy-SC force-pushed the offscreen-add-detach branch from 6481d14 to 65299dc Compare September 14, 2022 16:42
@sammy-SC sammy-SC requested review from acdlite and gaearon September 14, 2022 16:42
@sammy-SC sammy-SC marked this pull request as ready for review September 14, 2022 16:43
@sammy-SC sammy-SC force-pushed the offscreen-add-detach branch 2 times, most recently from d17ae6e to c3b7412 Compare September 14, 2022 19:09
sammy-SC
sammy-SC commented Sep 21, 2022
View reviewed changes
packages/react-reconciler/src/ReactFiberCommitWork.new.js Outdated
}

commitReconciliationEffects(finishedWork);
attachOffscreenActions(finishedWork, root);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be only called if Offscreen has manual interaction.

sammy-SC
sammy-SC commented Sep 21, 2022
View reviewed changes
packages/react-reconciler/src/ReactFiberCommitWork.new.js Outdated
}

function attachOffscreenActions(offscreenFiber: Fiber, root: FiberRoot) {
offscreenFiber.stateNode.detach = () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new method every single time. We should try to avoid this.
Maybe store current fiber on stateNode and reference that instead of offscreenFiber directly.

@sammy-SC sammy-SC force-pushed the offscreen-add-detach branch from c3b7412 to 16445f1 Compare September 23, 2022 15:05
Base automatically changed from offscreen-add-ref to main September 25, 2022 19:59
@sammy-SC sammy-SC force-pushed the offscreen-add-detach branch from 16445f1 to 49a409f Compare September 30, 2022 15:31
@sammy-SC sammy-SC force-pushed the offscreen-add-detach branch 2 times, most recently from 3baca4e to 2ca48e8 Compare October 11, 2022 14:49
sammy-SC
sammy-SC commented Oct 11, 2022
View reviewed changes
packages/react-reconciler/src/ReactFiberCommitWork.new.js Outdated
if (supportsMutation) {
// Offscreen with manual mode manages visibility manually.
const shouldControlChildrenVisibility =
finishedWork.memoizedProps === null ||
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acdlite is this the right approach? I fear that children will be hidden/shown on the first render pass even though Offscreen's mode is set to manual.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acdlite try to comment out memoizedProps and see what tests fail. To see if this is only an issue in legacy mode.

@sammy-SC
Copy link
Contributor Author

@acdlite this is ready for a review again. I'm looking into yarn_build_combined failure.

@sammy-SC sammy-SC force-pushed the offscreen-add-detach branch 3 times, most recently from ec2279d to a258012 Compare October 11, 2022 17:21
@sammy-SC sammy-SC requested a review from acdlite October 12, 2022 14:09
@sammy-SC sammy-SC force-pushed the offscreen-add-detach branch 2 times, most recently from f189031 to 5ec6f46 Compare October 13, 2022 14:47
@sammy-SC sammy-SC force-pushed the offscreen-add-detach branch from 5ec6f46 to eed79b5 Compare October 14, 2022 16:39
acdlite
acdlite approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, nice!

@sammy-SC sammy-SC merged commit 14072ce into main Oct 18, 2022
@sammy-SC sammy-SC deleted the offscreen-add-detach branch October 18, 2022 14:56
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Nov 1, 2022
@sammy-SC @facebook-github-bot
React Native sync for revisions 54f297a...ab075a2
f49b251 
Summary:
This sync includes the following changes:
- **[ab075a232](facebook/react@ab075a232 )**: Do not unmount layout effects on initial Offscreen mount ([#25592](facebook/react#25592)) //<Samuel Susla>//
- **[765805bf8](facebook/react@765805bf8 )**: Fix type check for null ([#25595](facebook/react#25595)) //<Sebastian Markbåge>//
- **[2ac77aab9](facebook/react@2ac77aab9 )**: Clean up vestige of useOpaqueIdentifier ([#25587](facebook/react#25587)) //<Andrew Clark>//
- **[bdd3d0807](facebook/react@bdd3d0807 )**: Extract logic for detecting bad fallback to helper //<Andrew Clark>//
- **[952dfff3f](facebook/react@952dfff3f )**: Split suspended work loop logic into separate functions //<Andrew Clark>//
- **[d2c0ab10d](facebook/react@d2c0ab10d )**: In work loop, add enum of reasons for suspending //<Andrew Clark>//
- **[5450dd409](facebook/react@5450dd409 )**: Strict Mode: Reuse memoized result from first pass ([#25583](facebook/react#25583)) //<Andrew Clark>//
- **[d2a0176a1](facebook/react@d2a0176a1 )**: Detect and warn if use(promise) is wrapped with try/catch block ([#25543](facebook/react#25543)) //<Andrew Clark>//
- **[cf3932be5](facebook/react@cf3932be5 )**: Remove old react-fetch, react-fs and react-pg libraries ([#25577](facebook/react#25577)) //<Sebastian Markbåge>//
- **[28a574ea8](facebook/react@28a574ea8 )**: Try assigning fetch to globalThis if global assignment fails ([#25571](facebook/react#25571)) //<Sebastian Markbåge>//
- **[09def5990](facebook/react@09def5990 )**: [Float] handle noscript context for Resources ([#25559](facebook/react#25559)) //<Josh Story>//
- **[17204056d](facebook/react@17204056d )**: [Float] fix coordination of resource identity and hydration ([#25569](facebook/react#25569)) //<Josh Story>//
- **[d925a8d0b](facebook/react@d925a8d0b )**: Flight client error stack ([#25560](facebook/react#25560)) //<Josh Story>//
- **[996b00b78](facebook/react@996b00b78 )**: [Tiny] Fixed incorrect import in `react-server-dom-webpack` ([#25554](facebook/react#25554)) //<Leo Lamprecht>//
- **[e7c5af45c](facebook/react@e7c5af45c )**: Update cache() and use() to the canary aka next channel ([#25502](facebook/react#25502)) //<Sebastian Markbåge>//
- **[fa77f52e7](facebook/react@fa77f52e7 )**: Unify promise switch statements //<Andrew Clark>//
- **[7572e4931](facebook/react@7572e4931 )**: Track thenable state in work loop //<Andrew Clark>//
- **[7fc3eefd8](facebook/react@7fc3eefd8 )**: Revert yieldy behavior for non-use Suspense (in Flight, too) //<Andrew Clark>//
- **[61f9b5e97](facebook/react@61f9b5e97 )**: [Float] support <base> as Resource ([#25546](facebook/react#25546)) //<Josh Story>//
- **[1d3fc9c9c](facebook/react@1d3fc9c9c )**: Bug fix when resolving cache ([#25545](facebook/react#25545)) //<Sebastian Markbåge>//
- **[cce18e350](facebook/react@cce18e350 )**: [Flight] Use AsyncLocalStorage to extend the scope of the cache to micro tasks ([#25542](facebook/react#25542)) //<Sebastian Markbåge>//
- **[caa84c8da](facebook/react@caa84c8da )**: Revert fetch instrumentation to only RSC ([#25540](facebook/react#25540)) //<Sebastian Markbåge>//
- **[0c11baa6a](facebook/react@0c11baa6a )**: add warnings for non-resources rendered outside body or head ([#25532](facebook/react#25532)) //<Josh Story>//
- **[9236abdb5](facebook/react@9236abdb5 )**: when float is enabled only push title and script as a single unit ([#25536](facebook/react#25536)) //<Josh Story>//
- **[dd5c20825](facebook/react@dd5c20825 )**: Revert yieldy behavior for non-use Suspense ([#25537](facebook/react#25537)) //<Andrew Clark>//
- **[934177598](facebook/react@934177598 )**: fix transposed escape functions ([#25534](facebook/react#25534)) //<Josh Story>//
- **[d1ced9fd5](facebook/react@d1ced9fd5 )**: [Float] support all links as Resources ([#25515](facebook/react#25515)) //<Josh Story>//
- **[973b90bdf](facebook/react@973b90bdf )**: [Float] support meta tags as Resources ([#25514](facebook/react#25514)) //<Josh Story>//
- **[79c582981](facebook/react@79c582981 )**: Let ReactDOM initialize in RSC ([#25503](facebook/react#25503)) //<Sebastian Markbåge>//
- **[1f7a2f577](facebook/react@1f7a2f577 )**: [Float] support title tags as Resources ([#25508](facebook/react#25508)) //<Josh Story>//
- **[c63580787](facebook/react@c63580787 )**: Support `use` in `act` testing API ([#25523](facebook/react#25523)) //<Andrew Clark>//
- **[65e32e58b](facebook/react@65e32e58b )**: Add fetch Instrumentation to Dedupe Fetches ([#25516](facebook/react#25516)) //<Sebastian Markbåge>//
- **[9336e29d9](facebook/react@9336e29d9 )**: [useEvent] Lint for presence of useEvent functions in dependency lists ([#25512](facebook/react#25512)) //<lauren>//
- **[3cc792bfb](facebook/react@3cc792bfb )**: [useEvent] Non-stable function identity ([#25473](facebook/react#25473)) //<lauren>//
- **[987292815](facebook/react@987292815 )**: Remove feature flag enableStrictEffects ([#25387](facebook/react#25387)) //<Samuel Susla>//
- **[8e2bde6f2](facebook/react@8e2bde6f2 )**: Add cache() API ([#25506](facebook/react#25506)) //<Sebastian Markbåge>//
- **[9cdf8a99e](facebook/react@9cdf8a99e )**: [Codemod] Update copyright header to Meta ([#25315](facebook/react#25315)) //<Andrew Clark>//
- **[e54015e26](facebook/react@e54015e26 )**: Refactor: fill in the flow missing type ([#25496](facebook/react#25496)) //<c0dedance>//
- **[3b1fd5767](facebook/react@3b1fd5767 )**: refactor: Flow: typing of Scheduler ([#25485](facebook/react#25485)) //<bubucuo>//
- **[14072ce64](facebook/react@14072ce64 )**: Add detach to Offscreen component ([#25265](facebook/react#25265)) //<Samuel Susla>//
- **[3bb71dfd4](facebook/react@3bb71dfd4 )**: Rename react-server-dom-webpack entry points to /client and /server ([#25504](facebook/react#25504)) //<Sebastian Markbåge>//
- **[71f2c8cf1](facebook/react@71f2c8cf1 )**: move resource acquisition to mutation phase ([#25500](facebook/react#25500)) //<Josh Story>//
- **[500bea532](facebook/react@500bea532 )**: Add option to load Fizz runtime from external file ([#25499](facebook/react#25499)) //<Andrew Clark>//
- **[4494f2a86](facebook/react@4494f2a86 )**: [Float] add support for scripts and other enhancements ([#25480](facebook/react#25480)) //<Josh Story>//
- **[9ecf84ed7](facebook/react@9ecf84ed7 )**: Bugfix: Suspending in shell during discrete update ([#25495](facebook/react#25495)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 54f297a...ab075a2

jest_e2e[run_all_tests]

Reviewed By: kassens

Differential Revision: D40897093

fbshipit-source-id: 6a040315834dea5c0ab994ea94d91f5605b9d6b0
rickhanlonii pushed a commit that referenced this pull request Dec 3, 2022
@sammy-SC @rickhanlonii
Add detach to Offscreen component (#25265)
073c2fa
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@sammy-SC @OlimpiaZurek
React Native sync for revisions 54f297a...ab075a2
5f93219 
Summary:
This sync includes the following changes:
- **[ab075a232](facebook/react@ab075a232 )**: Do not unmount layout effects on initial Offscreen mount ([facebook#25592](facebook/react#25592)) //<Samuel Susla>//
- **[765805bf8](facebook/react@765805bf8 )**: Fix type check for null ([facebook#25595](facebook/react#25595)) //<Sebastian Markbåge>//
- **[2ac77aab9](facebook/react@2ac77aab9 )**: Clean up vestige of useOpaqueIdentifier ([facebook#25587](facebook/react#25587)) //<Andrew Clark>//
- **[bdd3d0807](facebook/react@bdd3d0807 )**: Extract logic for detecting bad fallback to helper //<Andrew Clark>//
- **[952dfff3f](facebook/react@952dfff3f )**: Split suspended work loop logic into separate functions //<Andrew Clark>//
- **[d2c0ab10d](facebook/react@d2c0ab10d )**: In work loop, add enum of reasons for suspending //<Andrew Clark>//
- **[5450dd409](facebook/react@5450dd409 )**: Strict Mode: Reuse memoized result from first pass ([facebook#25583](facebook/react#25583)) //<Andrew Clark>//
- **[d2a0176a1](facebook/react@d2a0176a1 )**: Detect and warn if use(promise) is wrapped with try/catch block ([facebook#25543](facebook/react#25543)) //<Andrew Clark>//
- **[cf3932be5](facebook/react@cf3932be5 )**: Remove old react-fetch, react-fs and react-pg libraries ([facebook#25577](facebook/react#25577)) //<Sebastian Markbåge>//
- **[28a574ea8](facebook/react@28a574ea8 )**: Try assigning fetch to globalThis if global assignment fails ([facebook#25571](facebook/react#25571)) //<Sebastian Markbåge>//
- **[09def5990](facebook/react@09def5990 )**: [Float] handle noscript context for Resources ([facebook#25559](facebook/react#25559)) //<Josh Story>//
- **[17204056d](facebook/react@17204056d )**: [Float] fix coordination of resource identity and hydration ([facebook#25569](facebook/react#25569)) //<Josh Story>//
- **[d925a8d0b](facebook/react@d925a8d0b )**: Flight client error stack ([facebook#25560](facebook/react#25560)) //<Josh Story>//
- **[996b00b78](facebook/react@996b00b78 )**: [Tiny] Fixed incorrect import in `react-server-dom-webpack` ([facebook#25554](facebook/react#25554)) //<Leo Lamprecht>//
- **[e7c5af45c](facebook/react@e7c5af45c )**: Update cache() and use() to the canary aka next channel ([facebook#25502](facebook/react#25502)) //<Sebastian Markbåge>//
- **[fa77f52e7](facebook/react@fa77f52e7 )**: Unify promise switch statements //<Andrew Clark>//
- **[7572e4931](facebook/react@7572e4931 )**: Track thenable state in work loop //<Andrew Clark>//
- **[7fc3eefd8](facebook/react@7fc3eefd8 )**: Revert yieldy behavior for non-use Suspense (in Flight, too) //<Andrew Clark>//
- **[61f9b5e97](facebook/react@61f9b5e97 )**: [Float] support <base> as Resource ([facebook#25546](facebook/react#25546)) //<Josh Story>//
- **[1d3fc9c9c](facebook/react@1d3fc9c9c )**: Bug fix when resolving cache ([facebook#25545](facebook/react#25545)) //<Sebastian Markbåge>//
- **[cce18e350](facebook/react@cce18e350 )**: [Flight] Use AsyncLocalStorage to extend the scope of the cache to micro tasks ([facebook#25542](facebook/react#25542)) //<Sebastian Markbåge>//
- **[caa84c8da](facebook/react@caa84c8da )**: Revert fetch instrumentation to only RSC ([facebook#25540](facebook/react#25540)) //<Sebastian Markbåge>//
- **[0c11baa6a](facebook/react@0c11baa6a )**: add warnings for non-resources rendered outside body or head ([facebook#25532](facebook/react#25532)) //<Josh Story>//
- **[9236abdb5](facebook/react@9236abdb5 )**: when float is enabled only push title and script as a single unit ([facebook#25536](facebook/react#25536)) //<Josh Story>//
- **[dd5c20825](facebook/react@dd5c20825 )**: Revert yieldy behavior for non-use Suspense ([facebook#25537](facebook/react#25537)) //<Andrew Clark>//
- **[934177598](facebook/react@934177598 )**: fix transposed escape functions ([facebook#25534](facebook/react#25534)) //<Josh Story>//
- **[d1ced9fd5](facebook/react@d1ced9fd5 )**: [Float] support all links as Resources ([facebook#25515](facebook/react#25515)) //<Josh Story>//
- **[973b90bdf](facebook/react@973b90bdf )**: [Float] support meta tags as Resources ([facebook#25514](facebook/react#25514)) //<Josh Story>//
- **[79c582981](facebook/react@79c582981 )**: Let ReactDOM initialize in RSC ([facebook#25503](facebook/react#25503)) //<Sebastian Markbåge>//
- **[1f7a2f577](facebook/react@1f7a2f577 )**: [Float] support title tags as Resources ([facebook#25508](facebook/react#25508)) //<Josh Story>//
- **[c63580787](facebook/react@c63580787 )**: Support `use` in `act` testing API ([facebook#25523](facebook/react#25523)) //<Andrew Clark>//
- **[65e32e58b](facebook/react@65e32e58b )**: Add fetch Instrumentation to Dedupe Fetches ([facebook#25516](facebook/react#25516)) //<Sebastian Markbåge>//
- **[9336e29d9](facebook/react@9336e29d9 )**: [useEvent] Lint for presence of useEvent functions in dependency lists ([facebook#25512](facebook/react#25512)) //<lauren>//
- **[3cc792bfb](facebook/react@3cc792bfb )**: [useEvent] Non-stable function identity ([facebook#25473](facebook/react#25473)) //<lauren>//
- **[987292815](facebook/react@987292815 )**: Remove feature flag enableStrictEffects ([facebook#25387](facebook/react#25387)) //<Samuel Susla>//
- **[8e2bde6f2](facebook/react@8e2bde6f2 )**: Add cache() API ([facebook#25506](facebook/react#25506)) //<Sebastian Markbåge>//
- **[9cdf8a99e](facebook/react@9cdf8a99e )**: [Codemod] Update copyright header to Meta ([facebook#25315](facebook/react#25315)) //<Andrew Clark>//
- **[e54015e26](facebook/react@e54015e26 )**: Refactor: fill in the flow missing type ([facebook#25496](facebook/react#25496)) //<c0dedance>//
- **[3b1fd5767](facebook/react@3b1fd5767 )**: refactor: Flow: typing of Scheduler ([facebook#25485](facebook/react#25485)) //<bubucuo>//
- **[14072ce64](facebook/react@14072ce64 )**: Add detach to Offscreen component ([facebook#25265](facebook/react#25265)) //<Samuel Susla>//
- **[3bb71dfd4](facebook/react@3bb71dfd4 )**: Rename react-server-dom-webpack entry points to /client and /server ([facebook#25504](facebook/react#25504)) //<Sebastian Markbåge>//
- **[71f2c8cf1](facebook/react@71f2c8cf1 )**: move resource acquisition to mutation phase ([facebook#25500](facebook/react#25500)) //<Josh Story>//
- **[500bea532](facebook/react@500bea532 )**: Add option to load Fizz runtime from external file ([facebook#25499](facebook/react#25499)) //<Andrew Clark>//
- **[4494f2a86](facebook/react@4494f2a86 )**: [Float] add support for scripts and other enhancements ([facebook#25480](facebook/react#25480)) //<Josh Story>//
- **[9ecf84ed7](facebook/react@9ecf84ed7 )**: Bugfix: Suspending in shell during discrete update ([facebook#25495](facebook/react#25495)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 54f297a...ab075a2

jest_e2e[run_all_tests]

Reviewed By: kassens

Differential Revision: D40897093

fbshipit-source-id: 6a040315834dea5c0ab994ea94d91f5605b9d6b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acdlite acdlite acdlite approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

@gaearon gaearon Awaiting requested review from gaearon

+1 more reviewer

@Bluesky9876 Bluesky9876 Bluesky9876 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sammy-SC @sizebot @acdlite @Bluesky9876 @facebook-github-bot