fix: hooks returned by factory functions not linted #25066
Conversation
|
Hi @KATT! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Comparing: 17e2a15...a4a90f5 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
| { | ||
| code: ` | ||
| function createHooks() { | ||
| return { | ||
| useFoo: () => { | ||
| data: 'foo.useQuery' | ||
| }, | ||
| }; | ||
| } | ||
| const hooks = createHooks(); | ||
|
|
||
| const MyComponent = () => { | ||
| if (a) { | ||
| return; | ||
| } | ||
| const query = hooks.useFoo(); | ||
|
|
||
| return <>{query.data}</>; | ||
| } | ||
| `, | ||
| errors: [conditionalError('hooks.useFoo', true)], | ||
| }, |
| @@ -33,8 +43,7 @@ function isHook(node) { | |||
| isHook(node.property) | |||
| ) { | |||
| const obj = node.object; | |||
| const isPascalCaseNameSpace = /^[A-Z].*/; | |||
| return obj.type === 'Identifier' && isPascalCaseNameSpace.test(obj.name); | |||
| return obj.type === 'Identifier' && !nonHookNamespaces.includes(obj.name); | |||
There was a problem hiding this comment.
- I don't think the eslint rule should care if an object is PascalCased or not to decide whether the member is a hook or not.
- I don't know if having a list of allow-listed namespaces is acceptable, nor if such an alternative then should be configurable.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
🚧 🚧
Summary
Showcase #25065
How did you test this change?
Adding some tests to the lint test suite.