Disable ViewportMetrics unless MouseEvent lacks support for pageX/pageY #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!isMonitoringScrollValue) { | ||
| if (hasEventPageXY === undefined) { | ||
| hasEventPageXY = | ||
| document.createEvent && 'pageX' in document.createEvent('MouseEvent'); |
There was a problem hiding this comment.
I think @petehunt's plan was that we'd only access the DOM in files in src/browser/ui/ – but maybe ReactBrowserEventEmitter should be moved there?
This was referenced Oct 17, 2014
ashtuchkin
added a commit
to ashtuchkin/react
that referenced
this pull request
Nov 15, 2014
|
This seems pretty reasonable, though I know there's some internal FB code that uses ViewportMetrics that will need to be changed if we do this. |
|
What if we instead of detecting modern browsers we used a feature flag? It seems kinda niche, unless you are doing stuff with scrolling/long lists. |
|
@syranide This seems good – mind rebasing? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1300, only IE8 lacks
pageX/pageY(and perhaps really old FF or w/e I guess).From my #1300 (comment):
https://github.com/facebook/react/blob/master/src/browser/ui/ReactEventListener.js#L65
https://github.com/facebook/react/blob/master/src/browser/ui/ReactEventListener.js#L165
That makes no sense at all to me,
refreshdoes not take an argument, yet we get the scroll position and provide it as an argument. Instead,refreshgets the scroll position internally and uses that? So we callgetUnboundedScrollPositiontwice, but only use the result once (also, this should be broken for events inside iframes, for IE8).https://github.com/facebook/react/blob/master/src/browser/eventPlugins/TapEventPlugin.js#L54
I'm pretty sure any browsers that supports touch also supports
pageX/pageY... ?