Add new Jest --compact-console flag for DevTools tests #22495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag uses the @jest/console CustomConsole to override default formatting and remove the logging source location (making console logging more compact).
facebook-github-bot
added
the
React Core Team
|
Comparing: a4bc8ae...7e544a4 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
😭 |
|
@salazarm We could make the other test targets support this too. We'd just need to overhaul the console mocking stuff a little but and I didn't have the time to dig into this on the train. |
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag uses
CustomConsole(from@jest/console) to override default formatting and remove the logging source location (making the logs more compact and easier to read).Default logging (remains unchanged)
g console logging more compact).Example with
-cor--compact-consoleflagNote that this feature only supports the DevTools test targets because of the way reconciler tests mock console to verify that all expected warnings and errors were explicitly flushed before the end of the test.