DevTools should use reconciler version (rather than renderer version) #21269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
React Core Team
bvaughn
changed the title
eps1lon
reviewed
Apr 14, 2021
packages/react-devtools-shared/src/devtools/views/Components/InspectedElementView.js
Outdated
Show resolved
Hide resolved
bvaughn
force-pushed
the
devtools-use-reconciler-version
branch
from
cd39d93
to
0cc74e2
Compare
|
Comparing: 6b3d86a...0cc74e2 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gaearon
approved these changes
Apr 14, 2021
bvaughn
changed the title
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21262
Builds on top of #21268
The reconciler should inject its own version into DevTools so that tags/constants can be based on it. This will support 3rd party renderers that may use a different version scheme.