Skip to content

Prevent reading canonical property of null #21242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Prevent reading canonical property of null #21242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a95646
Prevent reading canonical property of null
JoshuaGross Apr 12, 2021
ee3ee63
prettier
JoshuaGross Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/react-native-renderer/src/ReactFabricGlobalResponderHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ import {UIManager} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateI
const ReactFabricGlobalResponderHandler = {
onChange: function(from: any, to: any, blockNativeResponder: boolean) {
Copy link
Member

@rickhanlonii rickhanlonii Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to flow type this?

Copy link
Contributor Author

@JoshuaGross JoshuaGross Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly "handles" like this seem to be consistently any-typed in the ReactNativeRenderer and in the Fabric renderer. So I guess I'm just going to leave as any for now? Seems odd

const fromOrTo = from || to;
const isFabric = !!fromOrTo.stateNode.canonical._internalInstanceHandle;
const fromOrToStateNode = fromOrTo && fromOrTo.stateNode;
const isFabric = !!(
fromOrToStateNode && fromOrToStateNode.canonical._internalInstanceHandle
);

if (isFabric) {
// Noop for now until setJSResponder/clearJSResponder are supported in Fabric
Expand Down