Skip to content

[Fizz] Move DOM/Native format configs to their respective packages #20994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2021
Merged

[Fizz] Move DOM/Native format configs to their respective packages #20994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d48f7
Move DOM/Native format configs to their respective packages
sebmarkbage Mar 13, 2021
bbcf4d1
Use escapeTextForBrowser to encode dynamic strings
sebmarkbage Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...-server/src/ReactDOMServerFormatConfig.js → .../src/server/ReactDOMServerFormatConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
convertStringToBuffer,
} from 'react-server/src/ReactServerStreamConfig';

import escapeTextForBrowser from './escapeTextForBrowser';
import invariant from 'shared/invariant';

// Per response,
Expand Down Expand Up @@ -46,13 +47,11 @@ export function createSuspenseBoundaryID(
}

function encodeHTMLIDAttribute(value: string): string {
// TODO: This needs to be encoded for security purposes.
return value;
return escapeTextForBrowser(value);
}

function encodeHTMLTextNode(text: string): string {
// TOOD: This needs to be encoded for security purposes.
return text;
return escapeTextForBrowser(text);
}

export function pushTextInstance(
Expand Down
0 ...rver/src/ReactNativeServerFormatConfig.js → ...c/server/ReactNativeServerFormatConfig.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/react-server/src/forks/ReactServerFormatConfig.dom-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
* @flow
*/

export * from '../ReactDOMServerFormatConfig';
export * from 'react-dom/src/server/ReactDOMServerFormatConfig';
2 changes: 1 addition & 1 deletion packages/react-server/src/forks/ReactServerFormatConfig.dom-relay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
* @flow
*/

export * from '../ReactDOMServerFormatConfig';
export * from 'react-dom/src/server/ReactDOMServerFormatConfig';
2 changes: 1 addition & 1 deletion packages/react-server/src/forks/ReactServerFormatConfig.dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
* @flow
*/

export * from '../ReactDOMServerFormatConfig';
export * from 'react-dom/src/server/ReactDOMServerFormatConfig';
2 changes: 1 addition & 1 deletion packages/react-server/src/forks/ReactServerFormatConfig.native-relay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
* @flow
*/

export * from '../ReactNativeServerFormatConfig';
export * from 'react-native-renderer/src/server/ReactNativeServerFormatConfig';