Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lane labels to scheduling profiler marks #20808

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Add Lane labels to scheduling profiler marks #20808

merged 2 commits into from
Feb 23, 2021

Commits on Feb 23, 2021

  1. Updated scheduling profiler Webpack config 

    1. Don't conflict with DevTools test shell port.
2. Add __VARIANT__ global since this is referenced in code now.
    Brian Vaughn committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    660fbfe View commit details
    Browse the repository at this point in the history

  2. Add Lane labels to scheduling profiler marks 

    This commit changes scheduling profiler marks from a format like '--schedule-render-1' to '--schedule-render-1-Sync' (where 1 is the numeric value of the Sync lane). This will enable the profiler itself to show more meaningful labels for updates and render work.

The commit also refactors and adds additional tests for the sceduling profiler package.

It also updates the preprocessor to 'support' instant events. These are no-ops for us, but adding recognition of the event type will prevent profiles imported from e.g. Chrome Canary from thorwing with an 'unrecognized event' error. (This will resolve issue facebook#20767.)
    Brian Vaughn committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    394bbd4 View commit details
    Browse the repository at this point in the history