Give displayName for all compositeComponent spec functions
#2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it('gives function a displayName for testing purposes', function() { | ||
| var a = function() {}; | ||
| var b = function() {}; | ||
| var c = function() {}; |
There was a problem hiding this comment.
Just inline these.
Edit: nevermind
|
@zpao that good enough? |
chenglou
force-pushed
the
handler-displayname
branch
2 times, most recently
from
138075b to
6aa327d
Compare
|
@zpao is this still relevant? |
|
Yes, this is still relevant. If you want to get it rebased that would be greatttttttt |
chenglou
force-pushed
the
handler-displayname
branch
from
6aa327d to
647ad63
Compare
|
@zpao done. |
|
@zpao ping |
chenglou
force-pushed
the
handler-displayname
branch
from
647ad63 to
9f31788
Compare
chenglou
force-pushed
the
handler-displayname
branch
from
9f31788 to
68a2f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was only given to a subset of the functions on the spec.
Fixes #3173.
@crm416 @zpao