Add a test for non-passive event handlers for events affected by the browsers' intervention #19658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7044514:
|
koba04
force-pushed
the
add-test-for-non-passive-event-handlers
branch
3 times, most recently
from
05a0986 to
60bfae7
Compare
Contributor
Author
|
My CircleCI builds are blocked and didn't run all builds I expect.. I'm not sure why this happens, so I have to investigate it. |
Contributor
Author
|
|
Contributor
Author
|
I've posted the issue on CircleCI's discuss. |
koba04
force-pushed
the
add-test-for-non-passive-event-handlers
branch
from
60bfae7 to
c14ed86
Compare
Contributor
Author
|
OK, I've fixed the problem, so this PR is ready for review. |
…browsers' intervention
koba04
force-pushed
the
add-test-for-non-passive-event-handlers
branch
from
c14ed86 to
7044514
Compare
Collaborator
|
thx |
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
…browsers' intervention (facebook#19658)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a test @trueadm has commented at #19654 (comment).
The test ensures that
unstable_createEventHandleisn't affected by browsers' intervention #19654 mentioned.Test Plan