feat: backport allowing noModule attribute on script tags to React 15 #19631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR backports this PR which added support for the
nomodule
attribute to React 15 as well. I'm not sure how likely this is to get into a release, but we're still stuck on React 15 for a variety of reasons. It would be great if we could add support for this attribute to React 15.https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-nomodule
Test Plan
The tests pass locally, though I didn't add a new test since it seems like we haven't added one for each attribute (example for the PR which added
nonce
here) though I could look into that if need be.