-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine isFiberSuspenseAndTimedOut #18184
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 38cf7f6:
|
This might not throw but this still seems like it'll yield the wrong results. The assumptions are still wrong about isFiberSuspenseAndTimedOut |
@sebmarkbage What are the correct assumptions? I can adjust accordingly. |
Add test case revise test title
cfeac53
to
38cf7f6
Compare
This changes the
isFiberSuspenseAndTimedOut
implementation based on Sebastian's feedback below: