Skip to content

Conversation

@threepointone
Copy link
Contributor

also includes a bugfix when downloading error codes from circleci.

[merging this right now, tagging reviewers just in case]

also includes a bugfix when downloading error codes from
@facebook-github-bot facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Feb 26, 2020
@threepointone threepointone merged commit c1c5499 into facebook:master Feb 26, 2020
@threepointone threepointone deleted the version-16.13 branch February 26, 2020 20:33
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

entry =>
entry.node_index === node_index &&
entry.path === 'home/circleci/project/scripts/error-codes/codes.json'
entry.path.endsWith('codes.json')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Sorry for missing this.

@sizebot
Copy link

sizebot commented Feb 26, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against ca66ce7

@sizebot
Copy link

sizebot commented Feb 26, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against ca66ce7

@DavidLozzi
Copy link

Did this break the build? When I pull this down I get error

No matching version found for scheduler@^0.19.0

and when I npm install scheduler i only get 0.18.0

@threepointone
Copy link
Contributor Author

probably a cache issue, since 0.19.0 is definitely up on npm https://www.npmjs.com/package/scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants