Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing stacks in WWW warnings #17638

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Fix missing stacks in WWW warnings #17638

merged 1 commit into from
Dec 17, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 17, 2019

Oops. I forgot them.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b0e1ad:

Sandbox Source
sleepy-joliot-rpgmh Configuration

@gaearon gaearon merged commit 3c54df0 into facebook:master Dec 17, 2019
@gaearon gaearon deleted the www-warn branch December 17, 2019 15:21
@sizebot
Copy link

sizebot commented Dec 17, 2019

Details of bundled changes.

Comparing: b66e86d...7b0e1ad

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +0.1% +0.2% 110.33 KB 110.43 KB 28.35 KB 28.4 KB UMD_DEV
react.production.min.js 0.0% -0.0% 12.52 KB 12.52 KB 4.9 KB 4.9 KB UMD_PROD
React-dev.js +1.6% +2.0% 69.11 KB 70.24 KB 17.73 KB 18.08 KB FB_WWW_DEV
React-prod.js 0.0% -0.0% 17.7 KB 17.7 KB 4.6 KB 4.6 KB FB_WWW_PROD
React-profiling.js 0.0% -0.0% 17.7 KB 17.7 KB 4.6 KB 4.6 KB FB_WWW_PROFILING
react.profiling.min.js 0.0% -0.0% 16.05 KB 16.05 KB 6.01 KB 6.01 KB UMD_PROFILING
react.development.js +0.1% +0.3% 69.83 KB 69.93 KB 18.67 KB 18.72 KB NODE_DEV
react.production.min.js 0.0% -0.1% 6.8 KB 6.8 KB 2.81 KB 2.81 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.07 KB 123.07 KB 38.8 KB 38.8 KB NODE_PROFILING
react-dom-server.browser.development.js +0.1% +0.1% 137.4 KB 137.5 KB 36.52 KB 36.56 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.39 KB 20.39 KB 7.48 KB 7.48 KB UMD_PROD
react-dom-test-utils.development.js +0.2% +0.3% 54.37 KB 54.47 KB 15.26 KB 15.31 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 711 B 710 B UMD_PROD
ReactDOMServer-dev.js +0.8% +0.8% 138.03 KB 139.16 KB 35.11 KB 35.4 KB FB_WWW_DEV
react-dom-test-utils.development.js +0.2% +0.3% 52.65 KB 52.75 KB 14.94 KB 14.98 KB NODE_DEV
ReactDOMServer-prod.js 0.0% -0.0% 48.86 KB 48.86 KB 11.16 KB 11.16 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 642 B 641 B NODE_PROD
react-dom.development.js 0.0% 0.0% 946.76 KB 946.86 KB 214.76 KB 214.81 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.12 KB 119.12 KB 38.43 KB 38.43 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 122.81 KB 122.81 KB 39.49 KB 39.49 KB UMD_PROFILING
ReactDOMUnstableNativeDependencies-dev.js +1.9% +2.5% 58.32 KB 59.45 KB 14.84 KB 15.22 KB FB_WWW_DEV
react-dom.development.js 0.0% 0.0% 940.83 KB 940.93 KB 213.1 KB 213.15 KB NODE_DEV
react-dom-server.node.development.js +0.1% +0.1% 134.44 KB 134.54 KB 35.74 KB 35.78 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 119.27 KB 119.27 KB 37.81 KB 37.81 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.73 KB 20.73 KB 7.61 KB 7.61 KB NODE_PROD
ReactTestUtils-dev.js +2.2% +2.5% 51.23 KB 52.37 KB 13.93 KB 14.28 KB FB_WWW_DEV
react-dom-server.browser.development.js +0.1% +0.1% 133.33 KB 133.43 KB 35.5 KB 35.54 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js +0.2% +0.3% 60.81 KB 60.91 KB 16.02 KB 16.07 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.23 KB 10.23 KB 3.48 KB 3.47 KB UMD_PROD
ReactDOM-dev.js +0.1% +0.1% 967.47 KB 968.6 KB 215.65 KB 215.97 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 402.69 KB 402.69 KB 73.52 KB 73.52 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js +0.2% +0.3% 60.51 KB 60.61 KB 15.94 KB 15.99 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
ReactDOM-profiling.js 0.0% -0.0% 403.61 KB 403.61 KB 74.09 KB 74.09 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 9.97 KB 9.97 KB 3.37 KB 3.37 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% 0.0% 611.56 KB 611.66 KB 130.72 KB 130.76 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.22 KB 71.22 KB 21.92 KB 21.91 KB UMD_PROD
ReactTestRenderer-dev.js +0.2% +0.2% 621.35 KB 622.49 KB 130.04 KB 130.34 KB FB_WWW_DEV
react-test-renderer-shallow.development.js +0.3% +0.5% 37.58 KB 37.68 KB 9.73 KB 9.78 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.6 KB 11.6 KB 3.58 KB 3.58 KB UMD_PROD
react-test-renderer-shallow.development.js +0.3% +0.6% 32.12 KB 32.22 KB 8.42 KB 8.47 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.73 KB 11.73 KB 3.69 KB 3.69 KB NODE_PROD
react-test-renderer.development.js 0.0% 0.0% 606.83 KB 606.93 KB 129.54 KB 129.58 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 70.93 KB 70.93 KB 21.55 KB 21.55 KB NODE_PROD
ReactShallowRenderer-dev.js +3.1% +3.6% 33.2 KB 34.23 KB 8.14 KB 8.43 KB FB_WWW_DEV

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/press-legacy.development.js +0.4% +0.8% 23.81 KB 23.91 KB 6.08 KB 6.13 KB UMD_DEV
react-interactions-events/hover.production.min.js 0.0% -0.2% 3.13 KB 3.13 KB 1.14 KB 1.14 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.26 KB 7.26 KB 2.73 KB 2.72 KB UMD_PROD
react-interactions-events/drag.development.js 0.0% -0.1% 5.24 KB 5.24 KB 1.55 KB 1.55 KB UMD_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 6.1 KB 6.1 KB 2.3 KB 2.29 KB UMD_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 6.01 KB 6.01 KB 1.63 KB 1.63 KB UMD_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.26 KB 2.26 KB 1.08 KB 1.08 KB UMD_PROD
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.44 KB 2.44 KB 1.24 KB 1.24 KB UMD_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.2% 2.46 KB 2.46 KB 1.12 KB 1.11 KB UMD_PROD
ReactEventsPressLegacy-dev.js +4.6% +7.1% 22.39 KB 23.42 KB 5.32 KB 5.7 KB FB_WWW_DEV
react-interactions-events/drag.development.js 0.0% -0.0% 7 KB 7 KB 2.22 KB 2.22 KB NODE_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.92 KB 5.92 KB 2.25 KB 2.25 KB NODE_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 5.83 KB 5.83 KB 1.59 KB 1.59 KB NODE_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.9 KB 2.9 KB 1.39 KB 1.39 KB NODE_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.2% 2.28 KB 2.28 KB 1.06 KB 1.06 KB NODE_PROD
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.69 KB 2.69 KB 1014 B 1013 B UMD_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.32 KB 6.32 KB 1.66 KB 1.66 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.4 KB 1.4 KB 737 B 736 B UMD_PROD
react-interactions-events/input.production.min.js 0.0% -0.1% 1.85 KB 1.85 KB 993 B 992 B UMD_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.1% 2.64 KB 2.64 KB 1.16 KB 1.16 KB UMD_PROD
ReactEventsPress-dev.js +17.9% +25.1% 5.78 KB 6.81 KB 1.57 KB 1.97 KB FB_WWW_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.13 KB 6.13 KB 1.62 KB 1.62 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 679 B 677 B NODE_PROD
react-interactions-events/input.production.min.js 0.0% -0.2% 1.67 KB 1.67 KB 927 B 925 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.2% 2.46 KB 2.46 KB 1.1 KB 1.1 KB NODE_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 6.83 KB 6.83 KB 1.52 KB 1.52 KB NODE_DEV
react-interactions-events/press-legacy.development.js +0.4% +0.8% 23.62 KB 23.72 KB 6.02 KB 6.07 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.3% 2.96 KB 2.96 KB 1.08 KB 1.08 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.08 KB 7.08 KB 2.67 KB 2.67 KB NODE_PROD
react-interactions-events/focus.development.js 0.0% -0.0% 15.7 KB 15.7 KB 3.27 KB 3.27 KB UMD_DEV
react-interactions-events/press.development.js +1.2% +2.0% 8.12 KB 8.22 KB 2.58 KB 2.63 KB UMD_DEV
react-interactions-events/tap.development.js 0.0% -0.0% 18.25 KB 18.25 KB 3.93 KB 3.93 KB UMD_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 5.34 KB 5.34 KB 1.77 KB 1.77 KB UMD_PROD
react-interactions-events/press.production.min.js 0.0% -0.3% 2.43 KB 2.43 KB 1015 B 1012 B UMD_PROD
react-interactions-events/tap.production.min.js 0.0% -0.1% 6.35 KB 6.35 KB 2.39 KB 2.39 KB UMD_PROD
react-interactions-events/press.development.js +1.3% +2.2% 7.83 KB 7.93 KB 2.5 KB 2.55 KB NODE_DEV
react-interactions-events/tap.development.js 0.0% -0.1% 18.07 KB 18.07 KB 3.88 KB 3.88 KB NODE_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 5.16 KB 5.16 KB 1.7 KB 1.7 KB NODE_PROD
react-interactions-events/press.production.min.js 0.0% -0.2% 2.14 KB 2.14 KB 927 B 925 B NODE_PROD
react-interactions-events/tap.production.min.js 0.0% -0.1% 6.18 KB 6.18 KB 2.35 KB 2.35 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +0.2% +0.2% 609.95 KB 611.08 KB 127.47 KB 127.78 KB FB_WWW_DEV
react-art.development.js 0.0% 0.0% 666.73 KB 666.83 KB 145.1 KB 145.14 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 106.19 KB 106.19 KB 32.35 KB 32.35 KB UMD_PROD
react-art.development.js 0.0% 0.0% 597.37 KB 597.47 KB 127.69 KB 127.73 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 71.16 KB 71.16 KB 21.5 KB 21.5 KB NODE_PROD

react-cache

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactCache-dev.js +13.8% +14.1% 7.5 KB 8.53 KB 2.45 KB 2.79 KB FB_WWW_DEV
react-cache.development.js +1.0% +1.4% 9.72 KB 9.82 KB 3.32 KB 3.37 KB UMD_DEV
react-cache.production.min.js 0.0% -0.2% 2.39 KB 2.39 KB 1.22 KB 1.22 KB UMD_PROD
react-cache.development.js +1.0% +1.6% 9.5 KB 9.6 KB 3.24 KB 3.29 KB NODE_DEV
react-cache.production.min.js 0.0% -0.1% 2.2 KB 2.2 KB 1.13 KB 1.13 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

React: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 7b0e1ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @trueadm @facebook-github-bot