Remove the condition argument from warning() #17568
Merged
+903
−1,047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 653965e:
|
Details of bundled changes.Comparing: 7bf40e1...653965e react
react-dom
react-test-renderer
react-native-renderer
react-art
react-cache
react-reconciler
react-is
ReactDOM: size: 0.0%, gzip: 0.0% React: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Details of bundled changes.Comparing: 7bf40e1...653965e react
react-dom
react-reconciler
react-art
react-test-renderer
react-native-renderer
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
gaearon
reviewed
Dec 10, 2019
| typeof subscribe === 'function', | ||
| 'Subscription must specify a subscribe function', | ||
| ); | ||
| if (!(typeof getCurrentValue === 'function')) { |
There was a problem hiding this comment.
Let's make a special case and convert these to !== negation directly.
gaearon
reviewed
Dec 10, 2019
| identifier, | ||
| MAX_TOUCH_BANK, | ||
| ); | ||
| if (!(identifier <= MAX_TOUCH_BANK)) { |
There was a problem hiding this comment.
Same for these. <= needs to flip to >, < needs to flip to >=, > needs to be <=, and >= needs to become <.
gaearon
reviewed
Dec 10, 2019
| warningWithoutStack( | ||
| typeof input === 'string' || | ||
| if ( | ||
| !( |
There was a problem hiding this comment.
For more complex conditions like this it's fine to leave them as is.
gaearon
requested changes
Dec 10, 2019
There was a problem hiding this comment.
- Let's detect
if (!(a === b))early and instead outputif (a !== b)and possibly the same for<and such. - Need to fix up
warningWithoutStack.www.js. It currently re-exportswarningfrom WWW. But it has the old API. SowarningWithoutStack.www.jsshould now export a function that calls the WWWwarningwithfalseas first argument.
this should be good now but lemme recheck tomorrow |
gaearon
reviewed
Dec 11, 2019
|
I still see the old |
gaearon
approved these changes
Dec 11, 2019
This was referenced Dec 11, 2019
|
👍, the previous usage of warning is In my option, it's naturally more to warn in the condition of true. if (true) {
warn('xxx')
}and why not write |
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* prep for codemod * prep warnings * rename lint rules * codemod for ifs * shim www functions * Handle more cases in the transform * Thanks De Morgan * Run the codemod * Delete the transform * Fix up confusing conditions manually * Fix up www shims to match expected API * Also check for low-pri warning in the lint rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 of #16753
warning-and-invariant-argsintowarning-argsandinvariant-args.toWarnDevandtoLowPriorityWarnDevdidn't actually need any changes as they track the underlying console calls