unify deprecated/unsafe lifecycle warnings, pass tests #16103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 9f39590...9505272 react-art
react-dom
react-test-renderer
react-reconciler
react-native-renderer
Generated by 🚫 dangerJS |
bvaughn
suggested changes
Jul 10, 2019
There was a problem hiding this comment.
These lifecycles are actually deprecated and will be removed in the next major version. I think changing the message to "not recommended" is a mistake.
Edit for clarity I think it's okay to say
Using UNSAFE_componentWillMount in strict mode is not recommended
But I don't think it's good to say:
Using componentWillMount in strict mode is not recommended
I think our warning needs to be more than just "not recommended" because the idea is that it will stop working in a future version.
|
Good point, happy to change it |
|
How do you feel about “...has been renamed to...”? I’m only trying to avoid the word ‘deprecated’. |
|
I am okay with "has been renamed to" in addition to advising against its usage. |
threepointone
force-pushed
the
lifecycle-warnings
branch
from
fd7faef
to
c1d0e06
Compare
|
I updated the diff only to pass the build error, will continue tweaking the wording. Still not 100% sure yet tbh. |
threepointone
commented
Jul 11, 2019
threepointone
force-pushed
the
lifecycle-warnings
branch
4 times, most recently
from
ec7b480
to
e7127aa
Compare
threepointone
force-pushed
the
lifecycle-warnings
branch
2 times, most recently
from
1c57951
to
d41920b
Compare
bvaughn
reviewed
Jul 11, 2019
packages/react-reconciler/src/__tests__/ReactIncremental-test.internal.js
Outdated
Show resolved
Hide resolved
threepointone
force-pushed
the
lifecycle-warnings
branch
4 times, most recently
from
abe5f20
to
e296fc4
Compare
trueadm
suggested changes
Jul 15, 2019
There was a problem hiding this comment.
The usage of the phrase "(preferred in most cases)" seems unnecessary and confusing to me. What cases? Why are they preferred in some cases but not others?
I think it's important we get this right, otherwise we're just going to cause pain for quite a large segment of users who are upgrading from an older version.
gaearon
reviewed
Jul 15, 2019
packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js
Outdated
Show resolved
Hide resolved
packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js
Outdated
Show resolved
Hide resolved
|
updated messages, screenshot. |
This was referenced Mar 10, 2020
This was referenced Mar 18, 2020
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the deprecated/unsafe lifecycle warnings.
warnAboutDeprecatedLifecyclesfor the test renderer. I think we missed doing so it previously. In a future PR, I'll remove the feature flag altogether.Things to do in future PRs asap -
Screenshot:
