Handle className properly on SVG nodes #1590
Conversation
This strategy avoids a runtime check for every set (as opposed to using a mutation method). Test Plan: Verify that changing className works on a div and a rect in latest Chrome, latest Firefox, IE9. Verify that the div works in IE8.
|
I think the real solution would be something like #1449 or #1512 (or both), but until then, this seems like a harmless fix 👍 . (PS. If we're serious about SVG, we/someone should probably also make a proper attempt at adding all SVG tags and attributes that doesn't currently conflict with anything in React.) |
|
I agree with @syranide (as he knows) and think an SVG plugin based on the 1.1 SVG IDLs would be awesome. http://www.w3.org/TR/SVG11/idl.html |
| implementation.hasFeature && | ||
| implementation.hasFeature( | ||
| 'http://www.w3.org/TR/SVG11/feature#BasicStructure', | ||
| '1.1' |
There was a problem hiding this comment.
Anywhere where we have to fallback to 1.0? I don't really know what I'm talking about so hopefully somebody else does...
There was a problem hiding this comment.
No idea, this is what art checks and it seems to work fine in IE9, at least. (@sebmarkbage?)
There was a problem hiding this comment.
It's don't work for me in these time.... my problem is a little bit different, look my post in the other page ;)
Handle className properly on SVG nodes
This strategy avoids a runtime check for every set (as opposed to using a mutation method).
Test Plan: Verify that changing className works on a div and a rect in latest Chrome, latest Firefox, IE9. Verify that the div works in IE8.