Skip to content

Conversation

cherniavskii
Copy link
Contributor

Fixes #15613

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @cherniavskii!

Implementation wise this looks solid to me. Do you mind adding a test as well? You can base it off this test case.

@cherniavskii
Copy link
Contributor Author

@philipp-spiess sure, I'll update this PR later

@cherniavskii
Copy link
Contributor Author

@philipp-spiess I've added a unit test, which fails without applying patch on this branch

Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you.

I can merge later if nobody objects 🙂

Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. This looks good to me.

@philipp-spiess philipp-spiess merged commit 4bf88dd into facebook:master May 16, 2019
@philipp-spiess
Copy link
Contributor

Thanks again 🙌

This was referenced Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<embed> doesn't trigger onLoad

4 participants