Backwards compat fix for ReactCurrentDispatcher on older react versions #14770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
force-pushed
the
current-owner-ref
branch
from
f1c26c2
to
8ab0da5
Compare
bvaughn
force-pushed
the
current-owner-ref
branch
from
8ab0da5
to
e8404c7
Compare
|
ReactDOM: size: 🔺+0.1%, gzip: 🔺+0.1% Details of bundled changes.Comparing: 0975ea3...6e638c9 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
react-debug-tools
Generated by 🚫 dangerJS |
acdlite
approved these changes
Feb 6, 2019
sebmarkbage
reviewed
Feb 6, 2019
| // but PR #14548 split them out to better support the react-debug-tools package. | ||
| if (!ReactSharedInternals.hasOwnProperty('ReactCurrentDispatcher')) { | ||
| const {ReactCurrentOwner} = ReactSharedInternals; | ||
| ReactSharedInternals.ReactCurrentDispatcher = { |
There was a problem hiding this comment.
Can't this just be {current: null}? Why does it need to forward to the owner object?
There was a problem hiding this comment.
Because I wasn't convinced that no 16.8+ renderer would ever have a valid use case for accessing current dispatcher?
There was a problem hiding this comment.
e.g. react-cache uses it
|
Okay, I've replaced the forwarding getter/setter with |
bvaughn
force-pushed
the
current-owner-ref
branch
from
d586b2b
to
6e638c9
Compare
|
We'll publish a bugfix release with this fix shortly |
|
Goddamn! |
|
@bvaughn do you think that this fix wouldn't happen if we could just test software a little bit more? |
|
I’m not sure if you’re genuinely asking or implying we didn’t test React. We spent weeks ironing out remaining issues in this release and at some point you just gotta publish. (You were welcome to try alphas which have been available for months, and the latest one had the same issue.) We’ll keep this particular situation in mind for the future (mismatching versions of React and ReactDOM). But we’re also humans and can make mistakes. If you don’t want our mistakes to break your code then you should be using lockfiles in a production environment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #14763.
Current owner and dispatcher used to share the same ref, but PR #14548 split them out to better support the
react-debug-toolspackage. This had the unintended side effect of newer renderers incompatible with versions of thereactpackage that predate this change.This PR adds a fallback property.