Minor fix params description for addPercent function #12669
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| @@ -53,7 +53,8 @@ function generateMDTable(headers, body) { | |||
|
|
|||
| /** | |||
| * Generates a user-readable string from a percentage change | |||
| * @param {string[]} headers | |||
| * @param {number} change | |||
| * @param {boolean} includeEmoji | |||
| */ | |||
| function addPercent(change, includeEmoji) { | |||
| if (!isFinite(change)) { | |||
There was a problem hiding this comment.
I just read some code in dangerFile. And found code on line 65
if (/^-|^0(?:\.0+)$/.test(formatted)) {I am not sure the purpose of this code, but when formatted equals -.2abc this .test(formatted) will also return true,( it will return true with any strings start with -) does it meet the expectation ? Or is it a bug?
If here just want to return formatted when change less than or equals 0, maybe replace this code by:
if (change <= 0) {
would be easier to understand.
There was a problem hiding this comment.
formatted should never be an arbitrary string, so cases like -2.abc aren't really a concern.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
We generally avoid merging changes that don't include any actual features/bug fixes, but since these JSDoc headers can confuse contributors this change seems fine. Thanks! |
|
Thanks! |
Just fix function's comment