Fix copy paste error for file size comparison #12040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, thanks |
|
Thanks! |
|
@gaearon If you'd like, you can take more direct advantage of the checks that lgtm does, and enable pull request integration here: https://lgtm.com/projects/g/facebook/react/ci/ This would help you to avoid situations such as that in #11865, by letting you know whenever new alerts would be introduced by merging the current PR. Full Disclosure: I'm a developer at lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a copy paste error for file size comparison in #11865 (#11865 (comment)).
I do not understand the tool chain well enough to make a test for this.
I found the error when looking through recent commits of this project on lgtm.com: https://lgtm.com/projects/g/facebook/react/