Prevent BeforeInputPlugin from returning [null, null] #11848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BeforeInputPlugin dispatches null elements in an array if composition or beforeInput events are not extracted. This causes a an extra array allocation, but more importantly creates null states in later event dispatch methods that are annoying to account for. This commit makes it so that BeforeInputPlugin never returns a null element inside an array.
nhunzaker
commented
Dec 14, 2017
| // Emoji test | ||
| {type: null}, | ||
| {type: null}, | ||
| {type: null}, |
There was a problem hiding this comment.
As far as I can tell, type: null are all of the null values from extractEvents, which could be a permutation of:
[null, null] // (neither a composition or beforeinput event)
[composition, beforeInput]
[null, beforeInput]
[composition, null]
So my change makes this change one of:
null
composition
beforeinput
[composition, beforeinput]
null gets filtered out by the EventPluginHub.extractEvents. It just does a basic null check, so [null, null] gets through.
jquense
approved these changes
Dec 14, 2017
aweary
approved these changes
Dec 14, 2017
There was a problem hiding this comment.
Looks like we tried doing this before but couldn't justify it 😄 if it simplifies some upstream code path then this LGTM
|
Hahaha. Looks it's me from many 🌔s ago. Dang. Thanks for sticking with me! |
yenshih
pushed a commit
to yenshih/react
that referenced
this pull request
Jan 6, 2018
The BeforeInputPlugin dispatches null elements in an array if composition or beforeInput events are not extracted. This causes a an extra array allocation, but more importantly creates null states in later event dispatch methods that are annoying to account for. This commit makes it so that BeforeInputPlugin never returns a null element inside an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeforeInputEventPlugindispatches null elements in an array if composition or beforeInput events are not extracted. This causes an extra array allocation, but more importantly creates null states in later event dispatch methods that are annoying to account for in some event system work I'm doing.TLDR: This commit makes it so that BeforeInputPlugin never returns a null element inside an array.