-
Notifications
You must be signed in to change notification settings - Fork 48.8k
Rewrite ReactTreeTraversal-test.js using public APIs #11664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gaearon
merged 10 commits into
facebook:master
from
timjacobi:tree-traversal-public-api
Nov 29, 2017
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
324641f
rewrite two phase traversal tests with public APIs
timjacobi c186e01
rewrite enter/leave tests
timjacobi e889dc4
lift render into beforeEach, organise variables
timjacobi c96f658
move getLowestCommonAncestor test
timjacobi 7c47c07
remove internal tree traversal test
timjacobi 185e5e0
fix linter errors
timjacobi 2847074
move creation of outer nodes into {before,after}Each
timjacobi 5f7bcd2
explain why getLowestCommonAncestor test was moved
timjacobi ee2992e
remove unnessecary ARG and ARG2 token
timjacobi fab27fb
run prettier
timjacobi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
241 changes: 0 additions & 241 deletions
241
packages/react-dom/src/__tests__/ReactTreeTraversal-test.internal.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're not using Responder plugin it's worth adding a comment explaining why the test is here and how it's related to Resonder.