Add a way to suppress DevTools logs and warnings #11448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Thanks! |
|
Verified that new webpack.DefinePlugin({
'__REACT_DEVTOOLS_GLOBAL_HOOK__': '({ isDisabled: true })'
}),is enough to make it disappear. |
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
This was referenced Feb 2, 2018
This was referenced Mar 1, 2018
This was referenced Mar 21, 2018
bobaekang
added a commit
to chicagopcdc/data-portal
that referenced
this pull request
Oct 14, 2021
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3877.
The idea is that the people who need it can shim the
__REACT_DEVTOOLS_GLOBAL_HOOK__global in their webpack/browserify configs with an object like({ isDisabled: true }).Basically same approach as I suggested in #3877 (comment), but doesn't produce an extra warning.