Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ReactCoroutine on __SECRET as unstable API #11311

Closed
wants to merge 1 commit into from

Conversation

jamiebuilds
Copy link

Opening PR for the sake of discussion after talking to @gaearon.

I've wanted to experiment with ReactCoroutine for awhile. I can copy the code into another project to try it out and I will, but Dan brought up adding it to __SECRET... so here's a PR

@jamiebuilds
Copy link
Author

Note: I didn't test or think about the actual contents of this change that much, I can fix it up if the team wants to do this.

@gaearon
Copy link
Collaborator

gaearon commented Oct 21, 2017

I think we could move it to react package since that's the right place for "isomorphic" stuff. I think we planned to move it there after it's more fleshed out, but might as well do now.

Then export it from packages/react/src/React.js in the secret field (there's already a few things there).

Existing imports of ReactCoroutine in the reconciler would then need to be changed to read it from that internal field of require('react'). There shouldn't be many.

Does this make sense?

@jamiebuilds
Copy link
Author

What should be done with the types being imported from ReactTypes?

Does it make sense to move the ReactTypes module into react as well?

@gaearon
Copy link
Collaborator

gaearon commented Oct 22, 2017

I think those should be moved to shared/. I think I did that in #11303 but it's not ready yet.

@gaearon
Copy link
Collaborator

gaearon commented Oct 25, 2017

Thanks for PR and the discussion. I went ahead and made a separate package for this. #11364

It will be out together with 16.1.

@gaearon gaearon closed this Oct 25, 2017
@jamiebuilds jamiebuilds deleted the react-coroutine branch October 25, 2017 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants