Ensure className={false} turns into string 'false' #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -180,15 +180,6 @@ var DefaultDOMPropertyConfig = { | |||
| srcDoc: 'srcdoc' | |||
| }, | |||
| DOMMutationMethods: { | |||
There was a problem hiding this comment.
Should be safe to just remove this whole object. Though it gets set to an empty object anyway.
|
I guess this supercedes #1072? Or should we do both? How is IE8 impacted? |
|
No, this doesn't fix SVG. We should do both in a way such that things still work in IE8. |
|
We need to update https://github.com/facebook/react/blob/master/src/browser/dom/__tests__/DOMPropertyOperations-test.js#L152-L166 as well. We should probably still test this path though. |
Fixes inconsistency shown by http://jsfiddle.net/zpao/qeXLm/.
zpao
added a commit
that referenced
this pull request
Feb 28, 2014
Ensure className={false} turns into string 'false'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes inconsistency shown by http://jsfiddle.net/zpao/qeXLm/.