15.6.1 source read #10754
Closed
15.6.1 source read #10754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release was a bit broken.
…ibing difference between React components, elements, and instances (facebook#9388) * Amended implementation-notes.md to include a link to a blog post by Dan Abramov, explaining the difference between components, elements, and instances. An understanding of this distinction is crucial in tracing through Implementation pseudocode, and reading Dan's blog first may ease newcomers into understanding the implementation. * adjusted wording to maintain stylistic consistency with rest of content, per @aweary's request
Removes doc about folder that no longer exists.
* Update typechecking-with-proptypes.md * Update typechecking-with-proptypes.md * Use consistent style for PropTypes import
…s Warning" doc page (facebook#9419) * Use the same prop-types link on the warning docs page as the main proptypes doc page * Link to repo instead
This API was never fully implemented. Since mixins are no longer considered part of the future React API, it will be removed.
The `.eslintignore` had gotten a merge conflict committed accidentally at some point, and also was not ignoring the `addons` directory. This fixes that. We also had a couple of missing commas that snuck in, and those are fixed here too.
* Clarification of setState() behavior `setState()` is a frequent source of confusion for people new to React, and I believe part of that is due to minimization of the impact of the asynchronous behavior of `setState()` in the documentation. This revision is an attempt to clarify that behavior. For motivation and justification, see [setState Gate](https://medium.com/javascript-scene/setstate-gate-abc10a9b2d82). * Update reference-react-component.md * Signature fix * Update to address @acdlite concerns * Add more details
* Update proptypes doc * Removed note
…k#9401) * Add tabs to installation page (facebook#9275, facebook#9277) This adds tabs for create-react-app and existing apps to the installation section of the docs. The tab implementation is a simplified version of React Native's installation page. Fixes facebook#9275. * Use classList instead of className * Use same implementation as in RN
…l not recieve the updated props (facebook#9404)
* Updated the Good First Bug section in readme * Inconsistent use of quotes. Prefered single quotes instead of double quotes * Updated Good first bug link in how_to_contribute doc. * Undo JSX attribute quote change * don't capitalize "beginner friendly issue" (cherry picked from commit 36c935c)
…#9349) * Impreove react-component of doc [facebook#9304](facebook#9304) * update description * add missing space (cherry picked from commit 359f5d2)
Previously two headings were 'Javascript Expressions' - now 'Javascript Expressions as Props' and 'Javascript Expressions as Children' (cherry picked from commit 363f6cb)
* Update jsx-in-depth.md Line 9 isn't changed * Move selection down * Fix (cherry picked from commit ccb38a9)
(cherry picked from commit 37f9e35)
… a synthetic event handler (facebook#9427) * Lift state up - Updating the documentation to mention that onClick is a synthetic event handler * Review comments - Rephrase to handle synthetic events and event handler patterns * Tweak (cherry picked from commit 53a3939)
* Update codebase-overview.md * Some more fixes (cherry picked from commit d724115)
* adds notes to tutorial on es6 and installation * fixes tutorial mention of opening button tag * More writing * Update
* Add addon changes to 15.6.0 changelog * Oops * Add to blogpost
**what is the change?:** Added an `eslintrc` which disables the 'comma-dangle' rule just for addons. **why make this change?:** To get CI passing again on the 15* branches. We don't have dangling commas in the addons because it breaks GCC under certain conditions. This doesn't affect React because we use Babel with React, but it's not worth setting up Babel for the addons at this time. **test plan:** `yarn lint` **issue:** None - hopefully will fix this before it's a problem
* Prevents adding units to css custom properties * Fix code style * Optimize custom property checking * Prevents adding units to css custom properties in markup creation * Update passing tests * Fix argument name and reuse check in DEV
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
This was referenced May 20, 2020
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done:
master.npm test).npm run prettier).npm run lint).npm run flow).