Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove toString-based minification check #10673

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Remove toString-based minification check #10673

merged 1 commit into from
Sep 11, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 11, 2017

Per discussion in #10640, seems like it might cause issues with extra string cache fetches and could potentially harm future toString change proposals.

Let’s just make sure DevTools surfaces this in a good way.

@gaearon gaearon mentioned this pull request Sep 11, 2017
Closed
@gaearon gaearon added this to the 16.0 milestone Sep 11, 2017
@gaearon gaearon mentioned this pull request Sep 11, 2017
Closed
sophiebits
sophiebits approved these changes Sep 11, 2017
View reviewed changes
Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gaearon gaearon merged commit 61282d3 into facebook:master Sep 11, 2017
This was referenced Sep 13, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiebits sophiebits sophiebits approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @sophiebits @facebook-github-bot