Skip to content

Remove data-reactid and data-react-checksum from whitelist #10402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Remove data-reactid and data-react-checksum from whitelist #10402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/renderers/dom/fiber/ReactDOMFiberComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,15 +931,9 @@ var ReactDOMFiberComponent = {
// TODO: Do we need to lower case this to get case insensitive matches?
var name = attributes[i].name;
switch (name) {
// Built-in attributes are whitelisted
// TODO: Once these are gone from the server renderer, we don't need
// this whitelist aynymore.
// Built-in SSR attribute is whitelisted
case 'data-reactroot':
break;
case 'data-reactid':
break;
case 'data-react-checksum':
break;
// Controlled attributes are not validated
// TODO: Only ignore them on controlled tags.
case 'value':
Expand Down