Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading wording in Documentation #9141

Closed
0xAl3xH opened this issue Mar 9, 2017 · 3 comments
Closed

Misleading wording in Documentation #9141

0xAl3xH opened this issue Mar 9, 2017 · 3 comments
Assignees

Comments

@0xAl3xH
Copy link

0xAl3xH commented Mar 9, 2017

Under "Lifting State Up":

The onClick doesn't have any special meaning here, but it's popular to name handler props starting with on and their implementations with handle.

is misleading because it is special and references the SyntheticEvent handlers. Instead, the documentation should give a brief description of why onClick was used and reference the section on SyntheticEvent to allow the users to see available handlers other than onClick.

@gaearon
Copy link
Collaborator

gaearon commented Mar 9, 2017

Agreed. Want to fix it? I think the intended meaning is that onClick inside div matters, but how you call a custom prop on your own component doesn’t.

@kkemple
Copy link

kkemple commented Mar 20, 2017

i can pick this up if no one else is jumping on it

@gaearon
Copy link
Collaborator

gaearon commented Apr 18, 2017

Fixed by #9427.

@gaearon gaearon closed this as completed Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants