Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: list and key examples override Number #8034

Closed
giuseppeg opened this issue Oct 21, 2016 · 2 comments
Closed

docs: list and key examples override Number #8034

giuseppeg opened this issue Oct 21, 2016 · 2 comments

Comments

@giuseppeg
Copy link
Contributor

Do you want to request a feature or report a bug?

bug

What is the current behavior?

In #8027 some examples use Number as component name

function Number(props) {
   // ...
}

Maybe it is a good idea to rename this component to NumberItem or something.
@gaearon
Copy link
Collaborator

gaearon commented Oct 21, 2016

Oops. I forgot it's a built-in thing.
I'll take a PR renaming it to ListItem.

@gaearon gaearon mentioned this issue Oct 21, 2016
Closed
15 tasks
@rthor
Copy link
Contributor

rthor commented Oct 21, 2016

I'll do it, if that's ok?

@rthor rthor mentioned this issue Oct 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@giuseppeg @gaearon @rthor