Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Children for void elements should throw instead of warn #3367

Closed
syranide opened this issue Mar 10, 2015 · 4 comments
Closed

Children for void elements should throw instead of warn #3367

syranide opened this issue Mar 10, 2015 · 4 comments
Labels
Difficulty: starter
Milestone
15.0

Comments

@syranide
Copy link
Contributor

#2266

Not to be released before React 0.14 is... or earlier if no one cares, as you absolutely shouldn't be doing this anyway.

This is mostly a reminder for myself, but feel free to take it.
@sophiebits
Copy link
Collaborator

Let's warn for a release. :)

@jimfb
Copy link
Contributor

jimfb commented Mar 10, 2015

It's already in as a warning for 0.13, right? So it's ready to be an error in 0.14 as per the conversation @syranide cited.

@sophiebits
Copy link
Collaborator

No, I just merged it for 0.14.

@jimfb jimfb added this to the 0.15 milestone Mar 10, 2015
@jonhester jonhester mentioned this issue Mar 11, 2015
Merged
@jimfb
Copy link
Contributor

jimfb commented Jan 29, 2016

Fixed in #3372

@jimfb jimfb closed this as completed Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: starter
Projects
None yet
Milestone
15.0
Development

No branches or pull requests
3 participants
@sophiebits @syranide @jimfb