Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Suspense/fallback adds a style display: none !important and this doesn't get removed on IE 11 #20054

Closed
AbGrS opened this issue Oct 19, 2020 · 8 comments
Assignees
Labels
Resolution: Needs More Information Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@AbGrS
Copy link

AbGrS commented Oct 19, 2020

Suspense/fallback wraps the components with display:none !important initially and somehow this style doesn't get removed automatically even after the components loads into the DOM on IE 11. Works fine on chrome through. If I manually remove this from the dev tool, you can see it shows up.

Seems like this is re-introduced:
#14114

React version: 16.12.0

<Suspense fallback={<CircularProgress />}> <Provider store={store}> <PersistGate loading={<div>Loading...</div>} persistor={persistor}> <Main /> </PersistGate> </Provider> </Suspense>

image

@AbGrS AbGrS added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Oct 19, 2020
@bvaughn
Copy link
Contributor

bvaughn commented Oct 19, 2020

It doesn't look like this bug report has enough info for one of us to reproduce it.

Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. Screenshots or videos can also be helpful if they help provide context on how to repro the bug.

Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

@AbGrS
Copy link
Author

AbGrS commented Oct 19, 2020

It doesn't look like this bug report has enough info for one of us to reproduce it.

Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. Screenshots or videos can also be helpful if they help provide context on how to repro the bug.

Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

Updated the comment. Please le me know if that's good enough.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 19, 2020

Please create a Code Sandbox that shows the problem.

@AbGrS
Copy link
Author

AbGrS commented Oct 19, 2020

Is there any option out there on Sandbox that selects other browser to see because the site doesn't even load directly on IE 11 so I can test my sample code.

@eps1lon
Copy link
Collaborator

eps1lon commented Oct 19, 2020

Is there any option out there on Sandbox that selects other browser to see because the site doesn't even load directly on IE 11.

Should work by deploying:

Add

"browserslist": {
  "production": [
    "IE 11"
  ],
  "development": [
    "IE 11"
  ]
}

to the package.json in your codesandbox, deploy (select Vercel or Netlify) from the "Deployment" panel and share the url to the deployed page.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 19, 2020

You can create the sandbox with Chrome/Firefox/Edge and then link to it. It doesn't need to be created in IE.

Alternately you could share a create-react-app project with us?

@amir-beheshty
Copy link

I believe this is similar issues as 18906 and 14114.
The display: none important! persists in IE-11.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 28, 2020

Closing this due to lack of a repro.

We can re-open it if more information gets added. 😄

@bvaughn bvaughn closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs More Information Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

4 participants